From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: balbi@ti.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.
Date: Thu, 21 Aug 2014 07:31:58 +0100 [thread overview]
Message-ID: <53F5925E.3010802@linaro.org> (raw)
In-Reply-To: <20140820155740.GF24500@saruman.home>
Thanks Felipe,
On 20/08/14 16:57, Felipe Balbi wrote:
> On Thu, Jul 17, 2014 at 09:16:40PM +0100, Srinivas Kandagatla wrote:
>> This patch makes the phy reset clk and reset line optional as this clk
>> is not available on boards like IFC6410 with APQ8064.
>>
>> phy-reset clk is only used as argument to the mach level callbacks, so
>> this patch adds condition before clk_get calls so that the driver
>> wouldn't fail on SOCs which do not have this support.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> Hi Felipe,
>>
>> With this new patch now the error message is only printed if the SOC actually supports
>> the phy reset clk, for SOCs like APQ8064 where there is no phy reset clock or
>> the callback which takes it there is no point in doing a clk_get call in the first place.
>
> doesn't apply. Please rebase on top of v3.17-rc1
>
this is because a previous version of the same patch got applied.
Anyway I will rebase this patch and send v3.
thanks,
srini
next prev parent reply other threads:[~2014-08-21 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 20:16 [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional Srinivas Kandagatla
2014-07-18 10:31 ` Prakash Burla
2014-08-20 15:57 ` Felipe Balbi
2014-08-20 15:57 ` Felipe Balbi
2014-08-21 6:31 ` Srinivas Kandagatla [this message]
2014-08-21 6:45 ` [PATCH v3] " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5925E.3010802@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.