From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ltris: fix linking with intl
Date: Thu, 21 Aug 2014 15:51:20 +0200 [thread overview]
Message-ID: <53F5F958.2000004@openwide.fr> (raw)
In-Reply-To: <20140821153629.38300748@free-electrons.com>
Hi Thomas,
Le 21/08/2014 15:36, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Tue, 19 Aug 2014 19:43:56 +0200, Romain Naour wrote:
>> ltris doen't build with (e)glibc toolchain since commit 454a41016f2f074b69e2c677f4749c213c653e86
>> when gettext package is selected.
>>
>> With (e)glibc libintl is provided by the libc whereas with uClibc it's provided by gettext.
>>
>> Linking with intl is only needed if the toolchain needs gettext and locale is set.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/821/82128cb9f5cd6ae2595a8302462f1b5719dad9f7/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> package/ltris/ltris.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks. However, it would be good if your commit logs were
> wrapped to a more reasonable length.
>
Sorry for that, I'll be more careful.
Also xscreensaver and procps-ng have the same problem, I'll send a patch for them.
Best regards,
Romain
prev parent reply other threads:[~2014-08-21 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 17:43 [Buildroot] [PATCH 1/1] package/ltris: fix linking with intl Romain Naour
2014-08-21 13:36 ` Thomas Petazzoni
2014-08-21 13:51 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5F958.2000004@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.