From: David Jeffery <djeffery@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: Always try and release an NFS file lock, even after receiving a SIGKILL
Date: Thu, 21 Aug 2014 11:40:12 -0400 [thread overview]
Message-ID: <53F612DC.60006@redhat.com> (raw)
In-Reply-To: <1408580933.4029.2.camel@leira.trondhjem.org>
On 08/20/2014 08:28 PM, Trond Myklebust wrote:
>
> What guarantees that this does not lead to silent corruption of the file
> if there are outstanding write requests?
>
Do you have a particular scenario in mind you are concerned about?
Right before the code the patch modifies, nfs_sync_mapping() is called.
Any writes started before the unlock operation began have already been
flushed, so we shouldn't have a corruption case of writes from before
the unlock began being sent after the unlock is complete.
Are you concerned about some other nfs4 writes being started while we
initially waited on the counter? Such a write racing with the unlock
going ahead instead of erroring out could initially fail from a wrong
state ID, but should retry with the new state. Is there something I've
overlooked?
David Jeffery
next prev parent reply other threads:[~2014-08-21 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1136742914.14501494.1407251366067.JavaMail.zimbra@redhat.com>
2014-08-05 15:17 ` [PATCH] nfs: Always try and release an NFS file lock, even after receiving a SIGKILL David Jeffery
2014-08-21 0:28 ` Trond Myklebust
2014-08-21 15:40 ` David Jeffery [this message]
2014-08-21 15:50 ` Trond Myklebust
2014-08-21 18:15 ` David Jeffery
2014-08-21 18:41 ` Trond Myklebust
2014-08-29 15:34 ` Benjamin Coddington
2014-08-29 15:51 ` Trond Myklebust
2014-08-29 16:31 ` Benjamin Coddington
2014-08-29 19:02 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F612DC.60006@redhat.com \
--to=djeffery@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.