From: Karol Babioch <karol@babioch.de>
To: Edward Lin <yidi.lin@canonical.com>, platform-driver-x86@vger.kernel.org
Cc: mattia Dongili <malattia@linux.it>
Subject: Re: [PATCH] ideapad-laptop: Use intel_backlight only on Lenovo B470e
Date: Fri, 22 Aug 2014 01:35:33 +0200 [thread overview]
Message-ID: <53F68245.20403@babioch.de> (raw)
In-Reply-To: <1408342153-16764-1-git-send-email-yidi.lin@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]
Hi Edward Lin,
Am 18.08.2014 um 08:09 schrieb Edward Lin:
> ACPI video is not functional on Lenovo B470e.
> The brightness control is also broken with vendor mode.
> The brightness control only works with intel_backlight.
By looking at your description (and your patch) I'm wondering how
exactly this problem made itself apparent? I'm having a similar (the
same?) issue with my Sony Vaio VPCS12C5E. The backlight interface
registered by ACPI does not work and I have to boot with the command
line option "acpi_backlight=vendor". Even then two interfaces get
registered "nv_backlight" and "sony", only one of which (nv_backlight)
works.
Desktop environments (GNOME in particular) seem to be confused by this,
so I always have to change the brightness by writing directly into the
"actual_brightness" file. I've reported this back in 2012 [1], but was
told that it is an ACPI issue and so it never was fixed.
Couldn't a similar patch be applied to the sony-laptop module? I've
added Mattia Dongili to the discussion, hopefully he doesn't mind to
take a look at this again. I'm glad to test any patches, but am not
familiar enough with all of the internal structs to mess around with
them for myself without breaking support for other users of this module,
especially since my model was shipped with in two different versions:
One with the internal Intel GPU and another with a dedicated Nvidia GPU.
I'm afraid a simple DMI match might not be good enough in this case?
Best regards,
Karol Babioch
[1]: http://www.spinics.net/lists/platform-driver-x86/msg03406.html
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-21 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 6:09 [PATCH] ideapad-laptop: Use intel_backlight only on Lenovo B470e Edward Lin
2014-08-21 23:35 ` Karol Babioch [this message]
2014-08-22 6:18 ` Yidi Lin
2015-01-19 3:14 ` AceLan Kao
2015-01-27 2:56 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F68245.20403@babioch.de \
--to=karol@babioch.de \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yidi.lin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.