Re: [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling

[Paolo Bonzini <pbonzini@redhat.com>]

Il 22/08/2014 04:01, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> variables lun and tag had been eliminated, break compiling
> when enable debug switch. Meanwhile traces provide the same
> information with this DPRINTF, so remove it.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2: 
>  - as Paolo's suggestion, remove the superfluous DPRINTF.
>  - change patch topic and commit message.
> ---
>  hw/scsi/scsi-generic.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 0b2ff90..0b352fc 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd)
>      SCSIDevice *s = r->req.dev;
>      int ret;
>  
> -    DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> -            r->req.cmd.xfer, cmd[0]);
> -
>  #ifdef DEBUG_SCSI
>      {
>          int i;
> 

Applied, thanks.

Paolo