From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKnO7-0007hH-6Z for qemu-devel@nongnu.org; Fri, 22 Aug 2014 07:52:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKnO1-0004yc-5b for qemu-devel@nongnu.org; Fri, 22 Aug 2014 07:52:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38390 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKnO0-0004yY-V7 for qemu-devel@nongnu.org; Fri, 22 Aug 2014 07:52:05 -0400 Message-ID: <53F72EE4.50402@suse.de> Date: Fri, 22 Aug 2014 13:52:04 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1408706366-43407-1-git-send-email-agraf@suse.de> <53F72C90.3050000@suse.de> <53F72D72.5050307@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] linux-user: Simplify boundary checks on g_posix_timers range List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Riku Voipio , QEMU Developers , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 22.08.14 13:49, Peter Maydell wrote: > On 22 August 2014 12:45, Alexander Graf wrote: >> On 22.08.14 13:44, Peter Maydell wrote: >>> On 22 August 2014 12:42, Alexander Graf wrote: >>>> Or we drop the AND and and the <0 check and treat arg1 as unsigned ;). >>> >>> That probably just requires equally many changes to >>> code that is currently correct because the arg* are >>> signed but would need changes if they became unsigned. >> >> Well, I do have a downstream patch that makes them unsigned, so I'd >> rather like to make the code as stable to that as I can ;). > > Yeah, I know. When I was looking through your patch tree > I saw that one and my reaction was "why on earth did > you do that?"... I don't fully remember all the glorious details either - and there's a good reason I never pushed it upstream :). It seemed to make the code more robust though. Maybe we'll just ditch it again sooner or later. Or push it upstream and make unsigned the default (which IMHO is a lot more sane, you get way less unwanted side effects). Alex