From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 22 Aug 2014 22:57:23 +0200 (CEST) Received: from mail-ie0-f172.google.com ([209.85.223.172]:54311 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27005160AbaHVU5Wc3lvH (ORCPT ); Fri, 22 Aug 2014 22:57:22 +0200 Received: by mail-ie0-f172.google.com with SMTP id lx4so7143323iec.17 for ; Fri, 22 Aug 2014 13:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=F7eMvZFWH/61OndSkIeTo2qrL+dSxJlieinbIk4p1qY=; b=z21QLKkYZ3eAATg02KHBtT2wccR0WoXT0MiplU/NL5aFmihAmWEfkbfEurL8VD3gd6 yYS5VHQ/4o2C6xt/WiWtlzDMbAbZGBnpzV/TBA0qSluHJEA+8U9hdWXTzdRGzg2fAvQK rT2MN07M6PhvZcSaRRTBUaG3BTTnl6YFIQcjTcsxFWYQkbfexaEvP/I6GBRT9ScGLb2w UToSYOqf9DnE95tSI8ZAKFqpoPjXD0UJrLpBFCWnh37JYiRG/XCN7RDIG24mCJ786IOO AoBUcqcwg/gbMBJEVneOmYJxZNSZqc+PyjD4t2I4vjNHtkF92S3RRHbrvLEQTxFXXNqF D7dg== X-Received: by 10.50.41.66 with SMTP id d2mr1060468igl.28.1408741039662; Fri, 22 Aug 2014 13:57:19 -0700 (PDT) Received: from dl.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPSA id 6sm2039589igt.20.2014.08.22.13.57.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 22 Aug 2014 13:57:18 -0700 (PDT) Message-ID: <53F7AEAC.90303@gmail.com> Date: Fri, 22 Aug 2014 13:57:16 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Florian Fainelli CC: Andrew Bresticker , Kumar Gala , Ralf Baechle , David Daney , Rob Herring , Linux-MIPS , Qais Yousef , Ian Campbell , "linux-kernel@vger.kernel.org" , Pawel Moll , John Crispin , Mark Rutland , Jayachandran C , Paul Burton , James Hogan , "devicetree@vger.kernel.org" Subject: Re: [PATCH 0/7] MIPS: Move device-tree files to a common location References: <1408651466-8334-1-git-send-email-abrestic@chromium.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42174 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney.cavm@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 08/22/2014 01:42 PM, Florian Fainelli wrote: > On Aug 21, 2014 3:05 PM, "Andrew Bresticker" > wrote: > > > > To be consistent with other architectures and to avoid unnecessary > > makefile duplication, move all MIPS device-trees to arch/mips/boot/dts > > and build them with a common makefile. > > I recall reading that the ARM organization for DTS files was a bit > unfortunate and should have been something like: > > arch/arm/boot/dts// > > Is this something we should do for the MIPS and update the other > architectures to follow that scheme? If we choose not to intermingle .dts files from all the vendors in a single directory, why do anything at all? Currently the .dts files for a vendor are nicely segregated with the rest of the vendors code under a single directory. Personally I think things are fine as they are. Any common code remaining in the Makefiles could be moved to the scripts directory for a smaller change. > > > > > Patch 1 sets up the makefiles for building the DTs in arch/mips/boot/dts > > and introduces the config option BUILTIN_DTB for platforms that require > > it. > > > > Patch 2 introduces the 'dtbs' makefile target to allow building of just > > the DT binaries. > > > > Patches 3-7 move the DTs out of the platform directores. > > > > I've build tested this on all affected platforms (Octeon, Lantiq, SEAD3, > > Netlogic, and Ralink) as well as Malta. For platforms where builtin DTBs > > are optional (Netlogic and Ralink), I built with and without the builtin > > DTBs. > > > > Based on 3.17-rc1. > > > > Andrew Bresticker (7): > > MIPS: Create common infrastructure for building built-in device-trees > > MIPS: Add support for building device-tree binaries > > MIPS: Octeon: Move device-trees to arch/mips/boot/dts/ > > MIPS: Lantiq: Move device-trees to arch/mips/boot/dts/ > > MIPS: sead3: Move device-trees to arch/mips/boot/dts/ > > MIPS: Netlogic: Move device-trees to arch/mips/boot/dts/ > > MIPS: ralink: Move device-trees to arch/mips/boot/dts/ > > > > arch/mips/Kconfig | 5 +++++ > > arch/mips/Makefile | 11 +++++++++++ > > arch/mips/boot/.gitignore | 1 + > > arch/mips/boot/dts/Makefile | 20 > ++++++++++++++++++++ > > arch/mips/{lantiq => boot}/dts/danube.dtsi | 0 > > arch/mips/{lantiq => boot}/dts/easy50712.dts | 0 > > arch/mips/{ralink => boot}/dts/mt7620a.dtsi | 0 > > arch/mips/{ralink => boot}/dts/mt7620a_eval.dts | 0 > > .../mips/{cavium-octeon => boot/dts}/octeon_3xxx.dts | 0 > > .../mips/{cavium-octeon => boot/dts}/octeon_68xx.dts | 0 > > arch/mips/{ralink => boot}/dts/rt2880.dtsi | 0 > > arch/mips/{ralink => boot}/dts/rt2880_eval.dts | 0 > > arch/mips/{ralink => boot}/dts/rt3050.dtsi | 0 > > arch/mips/{ralink => boot}/dts/rt3052_eval.dts | 0 > > arch/mips/{ralink => boot}/dts/rt3883.dtsi | 0 > > arch/mips/{ralink => boot}/dts/rt3883_eval.dts | 0 > > arch/mips/{mti-sead3 => boot/dts}/sead3.dts | 0 > > arch/mips/{netlogic => boot}/dts/xlp_evp.dts | 0 > > arch/mips/{netlogic => boot}/dts/xlp_fvp.dts | 0 > > arch/mips/{netlogic => boot}/dts/xlp_gvp.dts | 0 > > arch/mips/{netlogic => boot}/dts/xlp_svp.dts | 0 > > arch/mips/cavium-octeon/.gitignore | 2 -- > > arch/mips/cavium-octeon/Makefile | 10 ---------- > > arch/mips/lantiq/Kconfig | 1 + > > arch/mips/lantiq/Makefile | 2 -- > > arch/mips/lantiq/dts/Makefile | 1 - > > arch/mips/mti-sead3/Makefile | 4 ---- > > arch/mips/netlogic/Kconfig | 4 ++++ > > arch/mips/netlogic/Makefile | 1 - > > arch/mips/netlogic/dts/Makefile | 4 ---- > > arch/mips/ralink/Kconfig | 4 ++++ > > arch/mips/ralink/Makefile | 2 -- > > arch/mips/ralink/dts/Makefile | 4 ---- > > 33 files changed, 46 insertions(+), 30 deletions(-) > > create mode 100644 arch/mips/boot/dts/Makefile > > rename arch/mips/{lantiq => boot}/dts/danube.dtsi (100%) > > rename arch/mips/{lantiq => boot}/dts/easy50712.dts (100%) > > rename arch/mips/{ralink => boot}/dts/mt7620a.dtsi (100%) > > rename arch/mips/{ralink => boot}/dts/mt7620a_eval.dts (100%) > > rename arch/mips/{cavium-octeon => boot/dts}/octeon_3xxx.dts (100%) > > rename arch/mips/{cavium-octeon => boot/dts}/octeon_68xx.dts (100%) > > rename arch/mips/{ralink => boot}/dts/rt2880.dtsi (100%) > > rename arch/mips/{ralink => boot}/dts/rt2880_eval.dts (100%) > > rename arch/mips/{ralink => boot}/dts/rt3050.dtsi (100%) > > rename arch/mips/{ralink => boot}/dts/rt3052_eval.dts (100%) > > rename arch/mips/{ralink => boot}/dts/rt3883.dtsi (100%) > > rename arch/mips/{ralink => boot}/dts/rt3883_eval.dts (100%) > > rename arch/mips/{mti-sead3 => boot/dts}/sead3.dts (100%) > > rename arch/mips/{netlogic => boot}/dts/xlp_evp.dts (100%) > > rename arch/mips/{netlogic => boot}/dts/xlp_fvp.dts (100%) > > rename arch/mips/{netlogic => boot}/dts/xlp_gvp.dts (100%) > > rename arch/mips/{netlogic => boot}/dts/xlp_svp.dts (100%) > > delete mode 100644 arch/mips/cavium-octeon/.gitignore > > delete mode 100644 arch/mips/lantiq/dts/Makefile > > delete mode 100644 arch/mips/netlogic/dts/Makefile > > delete mode 100644 arch/mips/ralink/dts/Makefile > > > > -- > > 2.1.0.rc2.206.gedb03e5 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe devicetree" in > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html >