From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native.
Date: Sat, 23 Aug 2014 08:22:25 +0200 [thread overview]
Message-ID: <53F83321.1060906@web.de> (raw)
In-Reply-To: <xmqq61hknnjo.fsf@gitster.dls.corp.google.com>
On 2014-08-23 00.54, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
>> incorrectly set on Mingw git. However, the Makefile variable is not
>> propagated to the C preprocessor and results in no change. This patch
>> pushes the definition to the C code and adds a test to validate that
>> when core.eol as native is crlf, we actually normalize text files to this
>> line ending convention when core.autocrlf is false.
>>
>> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>> Signed-off-by: Stepan Kasal <kasal@ucw.cz>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>
> Who should I record as the author of this patch?
>
Sorry for missing this, here is what Mingw says:
commit 0caba2cacbb9d8e6a31783b45f1a13e52dec6ce8
Author: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Mon Nov 26 00:24:00 2012 +0000
Push the NATIVE_CRLF Makefile variable to C and added a test for native.
Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
[]
next prev parent reply other threads:[~2014-08-23 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 19:18 [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native Torsten Bögershausen
2014-08-22 22:54 ` Junio C Hamano
2014-08-23 6:22 ` Torsten Bögershausen [this message]
2014-08-25 17:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F83321.1060906@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.