All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Knabe <linux@thorsten-knabe.de>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, Thomas Meyer <thomas@m3y3r.de>,
	Valdis.Kletnieks@vt.edu, linux@thorsten-knabe.de
Subject: [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux
Date: Sat, 23 Aug 2014 15:47:38 +0200	[thread overview]
Message-ID: <53F89B7A.1040406@thorsten-knabe.de> (raw)

From: Thorsten Knabe <linux@thorsten-knabe.de>

UML: UBD: Fix for processes stuck in D state forever in UserModeLinux.

Starting with Linux 3.12 processes get stuck in D state forever in
UserModeLinux under sync heavy workloads. This bug was introduced by
commit 805f11a0d5 (um: ubd: Add REQ_FLUSH suppport).
Fix bug by adding a check if FLUSH request was successfully submitted to
the I/O thread and keeping the FLUSH request on the request queue on
submission failures.

Fixes: 805f11a0d5 (um: ubd: Add REQ_FLUSH suppport)
Signed-off-by: Thorsten Knabe <linux@thorsten-knabe.de>
---
Patch applies to 3.16.1.

diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 3716e69..b7d2840 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -1277,7 +1277,7 @@ static void do_ubd_request(struct request_queue *q)

 	while(1){
 		struct ubd *dev = q->queuedata;
-		if(dev->end_sg == 0){
+		if(dev->request == NULL){
 			struct request *req = blk_fetch_request(q);
 			if(req == NULL)
 				return;
@@ -1299,7 +1299,8 @@ static void do_ubd_request(struct request_queue *q)
 				return;
 			}
 			prepare_flush_request(req, io_req);
-			submit_request(io_req, dev);
+			if (submit_request(io_req, dev) == false)
+				return;
 		}

 		while(dev->start_sg < dev->end_sg){




-- 
___
 |        | /                 E-Mail: linux@thorsten-knabe.de
 |horsten |/\nabe                WWW: http://linux.thorsten-knabe.de

             reply	other threads:[~2014-08-23 14:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-23 13:47 Thorsten Knabe [this message]
2014-08-23 15:34 ` [PATCH] UML: UBD: Fix for processes stuck in D state forever in UserModeLinux Richard Weinberger
2014-08-23 17:43   ` Thorsten Knabe
2014-08-24 12:11     ` Richard Weinberger
2014-08-24 23:02       ` Thorsten Knabe
2014-08-25 13:25         ` Richard Weinberger
2014-08-25 14:00           ` Thorsten Knabe
2014-08-25 14:04             ` Richard Weinberger
2014-09-16 16:50               ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F89B7A.1040406@thorsten-knabe.de \
    --to=linux@thorsten-knabe.de \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@nod.at \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.