From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [PATCH v7 04/11] arm: Support restart through restart handler call chain Date: Sat, 23 Aug 2014 19:11:49 +0200 Message-ID: <53F8CB55.5030209@suse.de> References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-5-git-send-email-linux@roeck-us.net> <53F69DBA.4070806@suse.de> <20140822021947.GA17788@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140822021947.GA17788@roeck-us.net> Sender: linux-doc-owner@vger.kernel.org To: Guenter Roeck Cc: Heiko Stuebner , linux-doc@vger.kernel.org, Catalin Marinas , Tomasz Figa , Will Deacon , Doug Anderson , Wim Van Sebroeck , Ingo Molnar , linux-samsung-soc@vger.kernel.org, Russell King , Dmitry Eremin-Solenikov , linux-watchdog@vger.kernel.org, Arnd Bergmann , linux-pm@vger.kernel.org, Steven Rostedt , Maxime Ripard , linux-arm-kernel@lists.infradead.org, Randy Dunlap , linux-kernel@vger.kernel.org, Jonas Jensen , Andrew Morton , David Woodhouse List-Id: linux-pm@vger.kernel.org Am 22.08.2014 04:19, schrieb Guenter Roeck: > On Fri, Aug 22, 2014 at 03:32:42AM +0200, Andreas F=E4rber wrote: >> Am 20.08.2014 02:45, schrieb Guenter Roeck: >>> The kernel core now supports a restart handler call chain for syste= m >>> restart functions. >>> >>> With this change, the arm_pm_restart callback is now optional, so >>> drop its initialization and check if it is set before calling it. >>> Only call the kernel restart handler if arm_pm_restart is not set. >> [...] >>> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c >>> index 81ef686..ea279f7 100644 >>> --- a/arch/arm/kernel/process.c >>> +++ b/arch/arm/kernel/process.c >>> @@ -114,17 +114,13 @@ void soft_restart(unsigned long addr) >>> BUG(); >>> } >>> =20 >>> -static void null_restart(enum reboot_mode reboot_mode, const char = *cmd) >>> -{ >>> -} >>> - >>> /* >>> * Function pointers to optional machine specific functions >>> */ >>> void (*pm_power_off)(void); >>> EXPORT_SYMBOL(pm_power_off); >>> =20 >>> -void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *c= md) =3D null_restart; >>> +void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *c= md); >> >> Stupid newbie question maybe, but isn't this variable uninitialized = now, >> like any non-static variable in C99? Or does the kernel assure that = all >> such "fields" are zero-initialized? >> > It is initialized with NULL, like all other global and static variabl= es in the > kernel (and like pm_power_off a few lines above). Thanks for the explanation. In that case FWIW Reviewed-by: Andreas F=E4rber Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?ISO-8859-1?Q?Andreas_F=E4rber?=) Date: Sat, 23 Aug 2014 19:11:49 +0200 Subject: [PATCH v7 04/11] arm: Support restart through restart handler call chain In-Reply-To: <20140822021947.GA17788@roeck-us.net> References: <1408495538-27480-1-git-send-email-linux@roeck-us.net> <1408495538-27480-5-git-send-email-linux@roeck-us.net> <53F69DBA.4070806@suse.de> <20140822021947.GA17788@roeck-us.net> Message-ID: <53F8CB55.5030209@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 22.08.2014 04:19, schrieb Guenter Roeck: > On Fri, Aug 22, 2014 at 03:32:42AM +0200, Andreas F?rber wrote: >> Am 20.08.2014 02:45, schrieb Guenter Roeck: >>> The kernel core now supports a restart handler call chain for system >>> restart functions. >>> >>> With this change, the arm_pm_restart callback is now optional, so >>> drop its initialization and check if it is set before calling it. >>> Only call the kernel restart handler if arm_pm_restart is not set. >> [...] >>> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c >>> index 81ef686..ea279f7 100644 >>> --- a/arch/arm/kernel/process.c >>> +++ b/arch/arm/kernel/process.c >>> @@ -114,17 +114,13 @@ void soft_restart(unsigned long addr) >>> BUG(); >>> } >>> >>> -static void null_restart(enum reboot_mode reboot_mode, const char *cmd) >>> -{ >>> -} >>> - >>> /* >>> * Function pointers to optional machine specific functions >>> */ >>> void (*pm_power_off)(void); >>> EXPORT_SYMBOL(pm_power_off); >>> >>> -void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd) = null_restart; >>> +void (*arm_pm_restart)(enum reboot_mode reboot_mode, const char *cmd); >> >> Stupid newbie question maybe, but isn't this variable uninitialized now, >> like any non-static variable in C99? Or does the kernel assure that all >> such "fields" are zero-initialized? >> > It is initialized with NULL, like all other global and static variables in the > kernel (and like pm_power_off a few lines above). Thanks for the explanation. In that case FWIW Reviewed-by: Andreas F?rber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg