From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"
Date: Sun, 24 Aug 2014 15:30:47 +0400 [thread overview]
Message-ID: <53F9CCE7.3010006@cogentembedded.com> (raw)
In-Reply-To: <20140824064520.GA2578@katana>
Hello.
On 8/24/2014 10:45 AM, Wolfram Sang wrote:
>> This reverts commit 150b8be3cda54412ad7b54f5392b513b25c0aaa7.
>> The I2C core's per-adapter locks can't protect from IRQs, so the driver still
>> needs a spinlock to protect the register accesses.
> Looks to me like a plain revert. What about the issues you mentioned?
> Don't you want to fix them? Confused...
You told me to do 2 patches, one of them just revert. Here you are. As for
the follow up patch, I need to think a bit more, so all in a good time.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] Revert "i2c: rcar: remove spinlock"
Date: Sun, 24 Aug 2014 11:30:47 +0000 [thread overview]
Message-ID: <53F9CCE7.3010006@cogentembedded.com> (raw)
In-Reply-To: <20140824064520.GA2578@katana>
Hello.
On 8/24/2014 10:45 AM, Wolfram Sang wrote:
>> This reverts commit 150b8be3cda54412ad7b54f5392b513b25c0aaa7.
>> The I2C core's per-adapter locks can't protect from IRQs, so the driver still
>> needs a spinlock to protect the register accesses.
> Looks to me like a plain revert. What about the issues you mentioned?
> Don't you want to fix them? Confused...
You told me to do 2 patches, one of them just revert. Here you are. As for
the follow up patch, I need to think a bit more, so all in a good time.
WBR, Sergei
next prev parent reply other threads:[~2014-08-24 11:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 20:44 [PATCH v2] Revert "i2c: rcar: remove spinlock" Sergei Shtylyov
2014-08-23 20:44 ` Sergei Shtylyov
2014-08-24 6:45 ` Wolfram Sang
2014-08-24 6:45 ` Wolfram Sang
2014-08-24 11:30 ` Sergei Shtylyov [this message]
2014-08-24 11:30 ` Sergei Shtylyov
[not found] ` <53F9CCE7.3010006-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-08-25 3:40 ` Wolfram Sang
2014-08-25 3:40 ` Wolfram Sang
2014-08-25 11:35 ` Sergei Shtylyov
2014-08-25 11:35 ` Sergei Shtylyov
[not found] ` <53FB1F90.6080704-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2014-08-25 14:33 ` Wolfram Sang
2014-08-25 14:33 ` Wolfram Sang
2014-09-02 17:13 ` Sergei Shtylyov
2014-09-02 17:13 ` Sergei Shtylyov
2014-09-02 17:18 ` Wolfram Sang
2014-09-02 17:18 ` Wolfram Sang
2014-09-02 17:28 ` Sergei Shtylyov
2014-09-02 17:28 ` Sergei Shtylyov
2014-09-02 17:45 ` Wolfram Sang
2014-09-02 17:45 ` Wolfram Sang
2014-09-02 18:10 ` Sergei Shtylyov
2014-09-02 18:10 ` Sergei Shtylyov
2014-09-04 18:05 ` Wolfram Sang
2014-09-04 18:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F9CCE7.3010006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.