All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <boaz@plexistor.com>
To: Michal Marek <mmarek@suse.cz>,
	Stable Tree <stable@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: David Howells <dhowells@redhat.com>
Subject: [PATCH] Makefile: One last adjustment to relative paths
Date: Mon, 25 Aug 2014 11:50:07 +0300	[thread overview]
Message-ID: <53FAF8BF.3010008@plexistor.com> (raw)

From: Boaz Harrosh <boaz@plexistor.com>

I have one last problem when compiling under an IDE. This
time it is when I compile linux under another Makefile
with the use of
	make -C linux

The make command is run from /home/boaz/dev/
What the IDE will see is:
make[1]: Entering directory `/home/boaz/dev/linux-open-osd'

	This one is from the external make dev/Makefile

make[1]: Entering directory `.build_um'

       ^ This one is emulated by Linux Makefile
       ...

make[1]: Entering directory `.build_um'

       ^ This one is emulated by Linux Makefile again
error: ../foo/baz.c:XXX
       ...

The IDE will look for ../foo/baz.c at
	/home/boaz/dev/.build_um/../foo/baz.c ==
	/home/boaz/dev/foo/baz.c

This is because make will always print its "Entering directory"
full path or relative to the original make command, this is
make -C rules.

the simple fix is to have "Entering directory" print full path.

[Stable needed for 3.16]
CC: Stable Tree <stable@vger.kernel.org>
Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 6b27741..973c48f 100644
--- a/Makefile
+++ b/Makefile
@@ -178,7 +178,7 @@ $(filter-out _all sub-make $(CURDIR)/Makefile, $(MAKECMDGOALS)) _all: sub-make
  quiet_echodir := @echo
 silent_echodir := @:
 sub-make: FORCE
-	$($(quiet)echodir) "make[1]: Entering directory \`$(KBUILD_OUTPUT)'"
+	$($(quiet)echodir) "make[1]: Entering directory \`$(CURDIR)/$(KBUILD_OUTPUT)'"
 	$(if $(KBUILD_VERBOSE:1=),@)$(MAKE) -C $(KBUILD_OUTPUT) \
 	KBUILD_SRC=$(CURDIR) \
 	KBUILD_EXTMOD="$(KBUILD_EXTMOD)" -f $(CURDIR)/Makefile \
-- 
1.9.3


             reply	other threads:[~2014-08-25  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25  8:50 Boaz Harrosh [this message]
2014-08-25 13:40 ` [PATCH] Makefile: One last adjustment to relative paths Michal Marek
2014-08-26 14:24   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FAF8BF.3010008@plexistor.com \
    --to=boaz@plexistor.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.