From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, Kevin Wolf <kwolf@redhat.com>
Cc: benoit.canet@irqsave.net, maxa@catit.be, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]
Date: Mon, 25 Aug 2014 10:56:56 +0200 [thread overview]
Message-ID: <53FAFA58.2090807@redhat.com> (raw)
In-Reply-To: <53FA3D82.4090402@kamp.de>
Il 24/08/2014 21:31, Peter Lieven ha scritto:
> Am 24.08.2014 um 18:30 schrieb Paolo Bonzini:
>> Il 22/08/2014 10:42, Kevin Wolf ha scritto:
>>>> Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K depending
>>>> on the blocksize.
>>> I don't remember the details, but I think when I went through all
>>> drivers, I couldn't convince myself that a reasonable block size is
>>> enforced somewhere. So I just went ahead and converted the call to be on
>>> the safe side. It can never hurt anyway.
>> Yeah, a malicious iSCSI target could have unreasonable block sizes.
> Maybe we should just allow 512b or 4kb blocksize and refuse
> all other?
At least CDs and DVDs use 2kb blocksize. :)
Paolo
next prev parent reply other threads:[~2014-08-25 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00c425bd67fc66567dc683205f8f60f7.squirrel@ssl.dlhnet.de>
2014-08-22 7:40 ` [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations] Peter Lieven
2014-08-22 8:42 ` Kevin Wolf
2014-08-22 8:59 ` Peter Lieven
2014-08-24 16:30 ` Paolo Bonzini
2014-08-24 19:31 ` Peter Lieven
2014-08-25 8:56 ` Paolo Bonzini [this message]
2014-08-25 9:56 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FAFA58.2090807@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=maxa@catit.be \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.