From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
ian.campbell@citrix.com, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, kevin.tian@intel.com,
yang.z.zhang@intel.com
Cc: xen-devel@lists.xen.org
Subject: Re: [v4][PATCH 2/9] xen:x86: define a new hypercall to get RMRR mappings
Date: Mon, 25 Aug 2014 19:03:45 +0800 [thread overview]
Message-ID: <53FB1811.6080204@intel.com> (raw)
In-Reply-To: <53F7476D020000780002CB06@mail.emea.novell.com>
On 2014/8/22 19:36, Jan Beulich wrote:
>>>> On 22.08.14 at 12:53, <andrew.cooper3@citrix.com> wrote:
>> On 22/08/14 11:09, Tiejun Chen wrote:
>>> + /* PFN of the current mapping of the page. */
>>> + xen_pfn_t pfn;
>>> + /* Number of the current mapping pages. */
>>> + xen_ulong_t count;
>>> +};
>>
>> This struct marks a range, but the fields don't make it clear. I would
>> suggest "start" and "nr_frames" as names.
>
> Perhaps "start_pfn" to be even more explicit (and not just
> depend on the field's type), and then maybe also "nr_pfns"
> or "nr_pages".
>
Okay, I will go this combo, 'start_pfn' and 'nr_pages'.
Thanks
Tiejun
next prev parent reply other threads:[~2014-08-25 11:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 10:09 [v4][PATCH 0/9] xen: reserve RMRR to avoid conflicting MMIO/RAM Tiejun Chen
2014-08-22 10:09 ` [v4][PATCH 1/9] xen:vtd:rmrr: export acpi_rmrr_units Tiejun Chen
2014-08-22 10:09 ` [v4][PATCH 2/9] xen:x86: define a new hypercall to get RMRR mappings Tiejun Chen
2014-08-22 10:53 ` Andrew Cooper
2014-08-22 11:36 ` Jan Beulich
2014-08-25 11:03 ` Chen, Tiejun [this message]
2014-08-25 11:21 ` Chen, Tiejun
2014-08-25 12:07 ` Andrew Cooper
2014-08-26 3:12 ` Chen, Tiejun
2014-08-26 9:25 ` Andrew Cooper
2014-08-22 10:09 ` [v4][PATCH 3/9] tools:libxc: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-08-22 10:55 ` Andrew Cooper
2014-08-25 11:11 ` Chen, Tiejun
2014-08-25 11:58 ` Andrew Cooper
2014-08-22 10:09 ` [v4][PATCH 4/9] tools:libxc: check if mmio BAR is out of RMRR mappings Tiejun Chen
2014-08-26 20:36 ` Ian Campbell
2014-08-27 1:46 ` Chen, Tiejun
2014-08-27 2:20 ` Ian Campbell
2014-08-27 2:40 ` Chen, Tiejun
2014-08-27 2:47 ` Chen, Tiejun
2014-08-22 10:09 ` [v4][PATCH 5/9] hvm_info_table: introduce nr_reserved_device_memory_map Tiejun Chen
2014-08-26 20:38 ` Ian Campbell
2014-08-27 1:54 ` Chen, Tiejun
2014-08-27 1:57 ` Chen, Tiejun
2014-08-27 2:21 ` Ian Campbell
2014-08-27 2:28 ` Chen, Tiejun
2014-08-22 10:09 ` [v4][PATCH 6/9] xen:x86:: support xc_reserved_device_memory_map in compat case Tiejun Chen
2014-08-22 10:09 ` [v4][PATCH 7/9] tools:firmware:hvmloader: introduce hypercall for xc_reserved_device_memory_map Tiejun Chen
2014-08-22 10:09 ` [v4][PATCH 8/9] tools:firmware:hvmloader: check to reserve RMRR mappings in e820 Tiejun Chen
2014-08-22 10:09 ` [v4][PATCH 9/9] xen:vtd: make USB RMRR mapping safe Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB1811.6080204@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.