From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload Date: Mon, 25 Aug 2014 09:42:54 -0400 Message-ID: <53FB3D5E.6090200@mojatatu.com> References: <1408637945-10390-1-git-send-email-jiri@resnulli.us> <1408637945-10390-11-git-send-email-jiri@resnulli.us> <53F79C54.5050701@gmail.com> <464DB0A8-0073-4CE0-9483-0F36B73A53A1@cumulusnetworks.com> <53F9459B.2070801@mojatatu.com> <20140824111218.GA32741@casper.infradead.org> <53FA01AC.10507@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: ryazanov.s.a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ronye-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Neil.Jerram-QnUH15yq9NYqDJ6do+/SaQ@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Andy Gospodarek , dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, John Fastabend , jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ogerlitz , ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org, buytenh-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org, Jiri Pirko , roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org, aviadr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org, vyasevic-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Neil Horman , netdev , stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org, dborkman , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, David Miller To: Scott Feldman Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org On 08/24/14 22:24, Scott Feldman wrote: > > On Aug 24, 2014, at 8:15 AM, Jamal Hadi Salim wrote: > > > With respect to focus on L2/L3, I have a pretty *good* hunch someone could > write a kernel module that gleans from the L2/L3 netlink echoes already flying >around and translates to sw_flows and in turn into ndo_swdev_flow_* calls. And herein lies the fundamental disagreement. I dont believe the flow interface is appropriate for either L2/3. We already have some L2 interfaces (they are incomplete if you want to capture everything a large switch does). L3 should go the same path. And as i said earlier, i dont think the flow interface is appropriate as a universal classifier interface either. You need to allow for different types of classifiers. You need to allow for a mix and match of classifiers (although the later could be evolutionary). cheers, jamal