From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next RFC 10/12] openvswitch: add support for datapath hardware offload Date: Mon, 25 Aug 2014 09:53:25 -0400 Message-ID: <53FB3FD5.2030905@mojatatu.com> References: <1408637945-10390-1-git-send-email-jiri@resnulli.us> <1408637945-10390-11-git-send-email-jiri@resnulli.us> <53F79C54.5050701@gmail.com> <464DB0A8-0073-4CE0-9483-0F36B73A53A1@cumulusnetworks.com> <53F9459B.2070801@mojatatu.com> <20140824111218.GA32741@casper.infradead.org> <53FA01AC.10507@mojatatu.com> <53FAA2A2.7070801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: ryazanov.s.a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Neil.Jerram-QnUH15yq9NYqDJ6do+/SaQ@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Andy Gospodarek , dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, ronye-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, ogerlitz , ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org, buytenh-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org, Jiri Pirko , roopa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org, aviadr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org, vyasevic-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Neil Horman , netdev , stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org, dborkman , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, David Miller To: John Fastabend , Scott Feldman Return-path: In-Reply-To: <53FAA2A2.7070801-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Sender: "dev" List-Id: netdev.vger.kernel.org On 08/24/14 22:42, John Fastabend wrote: > In the L2 case we already have the fdb_add and fdb_del semantics that > are being used today by NICs with embedded switches. And we have a DSA > patch we could dig out of patchwork for those drivers. Indeed. That is an excellent starting point of something that is proven to work. I was hoping L3 would follow this path. For L2, there is the mess of claiming unicast NIC addresses as part of the fdb, but that can almost be ignored. Caveat: fdb_XXX works well for NICs as well as different larger ASICs - but some quark handling is going to be needed for the tinier openwrt type devices. For larger switches we are going to need more for L2: Really, the bridge already covers everthing large switches offer (Vlan filtering, bridge port setting etc). We just need to offload that... > So I think it makes more sense to use the explicit interface rather > than put another shim layer in the kernel. Its simpler and more to the > point IMO. I suspect the resulting code will be smaller and easier to > read. I'm the squemish one in the audience here. > L2/3 should be left alone and go this path. My concern on excessive NDOs was more on the flow view of the world. cheers, jamal > .John > >