From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH V3] Update pvSCSI protocol description
Date: Mon, 25 Aug 2014 16:35:36 +0200
Message-ID: <53FB49B8.9070305@suse.com>
References: <1408976584-22196-1-git-send-email-jgross@suse.com>
	<53FB64BF020000780002D503@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <53FB64BF020000780002D503@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, david.vrabel@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 08/25/2014 04:30 PM, Jan Beulich wrote:
>>>> On 25.08.14 at 16:23, <"jgross@suse.com".non-mime.internet> wrote:
>> +/*
>> + * The following interface is deprecated!
>> + */
>>   #define VSCSIIF_SG_LIST_SIZE ((sizeof(vscsiif_request_t) - 4) \
>>                                 / sizeof(vscsiif_segment_t))
>>
>
> Right, but ...
>
>> @@ -89,10 +224,12 @@ struct vscsiif_sg_list {
>>       vscsiif_segment_t seg[VSCSIIF_SG_LIST_SIZE];
>>   };
>>   typedef struct vscsiif_sg_list vscsiif_sg_list_t;
>> +/* End of deprecated interface */
>>
>> +/* Size of one response is 252 bytes */
>>   struct vscsiif_response {
>> -    uint16_t rqid;
>> -    uint8_t act;               /* valid only when backend supports SG_PRESET */
>> +    uint16_t rqid;          /* identifies request */
>> +    uint8_t padding;
>
> ... here you still remove a piece of that.

Indeed.

I'll post V4 tomorrow...


Juergen