From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver Date: Mon, 25 Aug 2014 13:36:30 -0600 Message-ID: <53FB903E.3050805@wwwdotorg.org> References: <1408381705-3623-1-git-send-email-abrestic@chromium.org> <1408381705-3623-7-git-send-email-abrestic@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1408381705-3623-7-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Bresticker , Thierry Reding , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Jassi Brar , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Arnd Bergmann , Kishon Vijay Abraham I , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > Add support for the on-chip xHCI host controller present on Tegra SoCs. > > The driver is currently very basic: it loads the controller with its > firmware, starts the controller, and is able to service messages sent > by the controller's firmware. The hardware supports device mode as > well as lower-power operating modes, but support for these is not yet > implemented here. Just one minor comment below. I'd like an ack from a USB maintainer so that this patch can be taken through the Tegra tree along with the rest of the series, which has various dependencies. > +MODULE_ALIAS("platform:xhci-tegra"); I don't think that's needed; MODULE_DEVICE_TABLE(of, tegra_xhci_of_match) should be enough upstream. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 25 Aug 2014 13:36:30 -0600 Subject: [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver In-Reply-To: <1408381705-3623-7-git-send-email-abrestic@chromium.org> References: <1408381705-3623-1-git-send-email-abrestic@chromium.org> <1408381705-3623-7-git-send-email-abrestic@chromium.org> Message-ID: <53FB903E.3050805@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > Add support for the on-chip xHCI host controller present on Tegra SoCs. > > The driver is currently very basic: it loads the controller with its > firmware, starts the controller, and is able to service messages sent > by the controller's firmware. The hardware supports device mode as > well as lower-power operating modes, but support for these is not yet > implemented here. Just one minor comment below. I'd like an ack from a USB maintainer so that this patch can be taken through the Tegra tree along with the rest of the series, which has various dependencies. > +MODULE_ALIAS("platform:xhci-tegra"); I don't think that's needed; MODULE_DEVICE_TABLE(of, tegra_xhci_of_match) should be enough upstream. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933403AbaHYTgJ (ORCPT ); Mon, 25 Aug 2014 15:36:09 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:37679 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754831AbaHYTgH (ORCPT ); Mon, 25 Aug 2014 15:36:07 -0400 Message-ID: <53FB903E.3050805@wwwdotorg.org> Date: Mon, 25 Aug 2014 13:36:30 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Andrew Bresticker , Thierry Reding , linux-tegra@vger.kernel.org CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Jassi Brar , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Arnd Bergmann , Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 6/9] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver References: <1408381705-3623-1-git-send-email-abrestic@chromium.org> <1408381705-3623-7-git-send-email-abrestic@chromium.org> In-Reply-To: <1408381705-3623-7-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2014 11:08 AM, Andrew Bresticker wrote: > Add support for the on-chip xHCI host controller present on Tegra SoCs. > > The driver is currently very basic: it loads the controller with its > firmware, starts the controller, and is able to service messages sent > by the controller's firmware. The hardware supports device mode as > well as lower-power operating modes, but support for these is not yet > implemented here. Just one minor comment below. I'd like an ack from a USB maintainer so that this patch can be taken through the Tegra tree along with the rest of the series, which has various dependencies. > +MODULE_ALIAS("platform:xhci-tegra"); I don't think that's needed; MODULE_DEVICE_TABLE(of, tegra_xhci_of_match) should be enough upstream.