From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/xscreensaver: fix linking with intl
Date: Mon, 25 Aug 2014 23:00:39 +0200 [thread overview]
Message-ID: <53FBA3F7.2000501@openwide.fr> (raw)
In-Reply-To: <20140825200144.187d22ad@free-electrons.com>
Hi Thomas,
Le 25/08/2014 20:01, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Thu, 21 Aug 2014 15:56:06 +0200, Romain Naour wrote:
>
>> diff --git a/package/xscreensaver/xscreensaver.mk b/package/xscreensaver/xscreensaver.mk
>> index 0e84d27..ac8b09d 100644
>> --- a/package/xscreensaver/xscreensaver.mk
>> +++ b/package/xscreensaver/xscreensaver.mk
>> @@ -14,7 +14,7 @@ XSCREENSAVER_LICENSE_FILES = hacks/screenhack.h hacks/glx/chessmodels.h
>> XSCREENSAVER_DEPENDENCIES = jpeg libglade libgtk2 xlib_libX11 xlib_libXt \
>> $(if $(BR2_PACKAGE_GETTEXT),gettext)
>>
>> -XSCREENSAVER_CONF_ENV = $(if $(BR2_PACKAGE_GETTEXT),LIBS=-lintl)
>> +XSCREENSAVER_CONF_ENV = $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
>
> I am not convinced by this one, because in XSCREENSAVER_DEPENDENCIES,
> the gettext dependency is still added when BR2_PACKAGE_GETTEXT=y. And
> also, in the Config.in of this package, there is nothing like select
> BR2_PACKAGE_GETTEXT if !BR2_NEEDS_GETTEXT_IF_LOCALE.
>
Ok, I'll rework on it :)
Best regards,
Romain
prev parent reply other threads:[~2014-08-25 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 13:56 [Buildroot] [PATCH 1/2] package/xscreensaver: fix linking with intl Romain Naour
2014-08-21 13:56 ` [Buildroot] [PATCH 2/2] package/procps-ng: " Romain Naour
2014-08-21 14:21 ` Vicente Olivert Riera
2014-08-25 17:55 ` Thomas Petazzoni
2014-08-25 18:01 ` [Buildroot] [PATCH 1/2] package/xscreensaver: " Thomas Petazzoni
2014-08-25 21:00 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FBA3F7.2000501@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.