From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH envytools] nvbios: Write missing null terminating byte.
Date: Tue, 26 Aug 2014 00:37:50 +0200 [thread overview]
Message-ID: <53FBBABE.4040701@free.fr> (raw)
In-Reply-To: <1408993096-18883-5-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 25/08/2014 20:58, Christian Costa wrote:
> ---
> nvbios/nvbios.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nvbios/nvbios.c b/nvbios/nvbios.c
> index 4fc667b..7bb768a 100644
> --- a/nvbios/nvbios.c
> +++ b/nvbios/nvbios.c
> @@ -797,9 +797,9 @@ void find_strap(char *filename) {
>
> path = (char*) malloc(base_length + strlen(strap_filename)+1);
> strncpy(path, filename, base_length);
> - strncpy(path+base_length, strap_filename, strlen(strap_filename));
> + strncpy(path+base_length, strap_filename, strlen(strap_filename)+1);
>
> - if(!set_strap_from_file(path))
> + if (!set_strap_from_file(path))
> printf("Strap register found in '%s'\n", path);
>
> free(path);
Looks good
next prev parent reply other threads:[~2014-08-25 22:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 18:58 [PATCH envytools] demmio: Add decoding of some MEM_TIMINGS registers for NVC0 Christian Costa
[not found] ` <1408993096-18883-1-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-25 18:58 ` [PATCH envytools] docs: Fix some spelling and remove some trailing spaces Christian Costa
[not found] ` <1408993096-18883-2-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-25 22:32 ` Martin Peres
2014-08-25 18:58 ` [PATCH envytools] nva: Clean up nva tools doc Christian Costa
[not found] ` <1408993096-18883-3-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-25 22:35 ` Martin Peres
[not found] ` <53FBBA3F.50405-GANU6spQydw@public.gmane.org>
2014-08-25 22:55 ` Ilia Mirkin
[not found] ` <CAKb7Uvj4=vM0kSQB3npNyeMT3=AjMy6mTE5-iFu-ZqHpOCCq+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-26 2:30 ` Christian Costa
2014-08-26 2:20 ` Christian Costa
2014-08-25 18:58 ` [PATCH envytools] nvbios: Return an error if mem train subentries is above the limit to avoid stack corruption Christian Costa
2014-08-25 18:58 ` [PATCH envytools] nvbios: Write missing null terminating byte Christian Costa
[not found] ` <1408993096-18883-5-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-25 22:37 ` Martin Peres [this message]
2014-08-25 18:58 ` [PATCH envytools] nvbios: Check if HWEA entry length == -1 Christian Costa
2014-08-25 18:58 ` [PATCH envytools] Don't try to use bios->pars if NULL (parse_pcir function has probably failed) Christian Costa
[not found] ` <1408993096-18883-7-git-send-email-titan.costa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-25 19:09 ` Ilia Mirkin
[not found] ` <CAKb7UvhnRp55JtHgW7WOxmwUXWeUO_Ow4ub0LoGHWMhTx005rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-26 2:32 ` Christian Costa
2014-08-25 22:30 ` [PATCH envytools] demmio: Add decoding of some MEM_TIMINGS registers for NVC0 Martin Peres
[not found] ` <53FBB903.7060900-GANU6spQydw@public.gmane.org>
2014-08-26 2:06 ` Christian Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FBBABE.4040701@free.fr \
--to=martin.peres-ganu6spqydw@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.