All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] filter: update xfs_repair filter for new sunit/swidth warning
Date: Mon, 25 Aug 2014 17:43:50 -0500	[thread overview]
Message-ID: <53FBBC26.20700@sandeen.net> (raw)
In-Reply-To: <1409006043-31495-3-git-send-email-david@fromorbit.com>

On 8/25/14, 5:34 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> New xfs_repair programs have a different sunit/swidth warning that
> is triggering failures such as:
> 
>     -Note - stripe unit (0) and width (0) fields have been reset.
>     -Please set with mount -o sunit=<value>,swidth=<value>
>     +Note - stripe unit (0) and width (0) were copied from a backup superblock.
>     +Please reset with mount -o sunit=<value>,swidth=<value> if necessary
> 
> Update the filter to catch both cases and output the old message so
> tests pass again.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Ah, crap, I forgot to do this, I'm sorry.  Thanks.

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  common/repair | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/common/repair b/common/repair
> index 46ca9e0..a157580 100644
> --- a/common/repair
> +++ b/common/repair
> @@ -85,6 +85,9 @@ s/\s+- \d+:\d\d:\d\d:.*\n//g;
>  /^agfl has bad CRC/ && next;
>  # finobt enabled filesystem output
>  s/(inode chunk) (\d+)\/(\d+)/AGNO\/INO/;
> +# sunit/swidth reset messages
> +s/^(Note - .*) were copied.*/\1 fields have been reset./;
> +s/^(Please) reset (with .*) if necessary/\1 set \2/;
>  	print;'
>  }
>  
> 


      reply	other threads:[~2014-08-25 22:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-25 22:34 [PATCH 0/2] xfstests: regression fixes Dave Chinner
2014-08-25 22:34 ` [PATCH 1/2] common: don't check scratch dev on all tests Dave Chinner
2014-08-25 22:34 ` [PATCH 2/2] filter: update xfs_repair filter for new sunit/swidth warning Dave Chinner
2014-08-25 22:43   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FBBC26.20700@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.