From: Eric Blake <eblake@redhat.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] bad error message in drive-mirror
Date: Mon, 25 Aug 2014 17:26:31 -0600 [thread overview]
Message-ID: <53FBC627.1000209@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
I just noticed today that passing "granularity":1 to QMP drive-mirror
results in this confusing error message:
Invalid parameter 'drive-virtio-disk0'
because the code mistakenly did
error_set(errp, QERR_INVALID_PARAMETER, device);
instead of the correct
error_set(errp, QERR_INVALID_PARAMETER, "granularity");
I ran out of time to patch it today, and at any rate, whoever writes the
patch should probably audit for other bad uses of
error_set(QERR_INVALID_PARAMETER).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next reply other threads:[~2014-08-25 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 23:26 Eric Blake [this message]
2014-08-27 13:30 ` [Qemu-devel] bad error message in drive-mirror Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FBC627.1000209@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.