All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] configs/freescale_imx6dlsabresd: add defconfig for iMX6DL SabreSD
Date: Tue, 26 Aug 2014 09:36:51 +0200	[thread overview]
Message-ID: <53FC3913.3060007@lucaceresoli.net> (raw)
In-Reply-To: <CADCpmyN=pUb+fMjDwxQFbPCY-59=s4Ont82UuW1FUu452Ng23w@mail.gmail.com>

Dear Gary,

Gary Bisson wrote:
> Hi Luca,
>
> On Thu, Aug 14, 2014 at 5:36 AM, Luca Ceresoli <luca@lucaceresoli.net
> <mailto:luca@lucaceresoli.net>> wrote:
>
>     This is very similar to freescale_imx6sabresd_defconfig, which
>     supports the
>     i.MX6Q ("Quad", quad core CPU) version of the board, except it
>     supports the
>     i.MX6DL (DualLite, dual core CPU) version.
>
>     The differences are in the U-boot configuration and the device tree
>     file.
>
>
> Looks good to me, however I would then rename the previous
> freescale_imx6sabresd_defconfig to freescale_imx6qsabresd_defconfig in
> order for it to be clear.

I was not sure it's a good idea to rename a defconfig, but I see we've
done it before at least once:

     commit 094d8ec896ef0c447a4bfb884753bf8984d67dbc
     Author: mathieu benoit <mathieu.benoit@savoirfairelinux.com>
     Date:   Sun Nov 10 13:16:22 2013 +0100

         configs: rename rpi_defconfig for consistency

     [...]

      board/raspberrypi/readme.txt  |  8 ++++----
      configs/raspberrypi_defconfig | 23 +++++++++++++++++++++++
      configs/rpi_defconfig         | 23 -----------------------
      3 files changed, 27 insertions(+), 27 deletions(-)

So I'll resubmit my patchset with this added.

Thanks,
-- 
Luca

      reply	other threads:[~2014-08-26  7:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 12:36 [Buildroot] [PATCH v2 1/2] configs/freescale_imx6dlsabresd: add defconfig for iMX6DL SabreSD Luca Ceresoli
2014-08-14 12:36 ` [Buildroot] [PATCH v2 2/2] freescale/imx6-sabresd: document how to create a bootable SD Luca Ceresoli
2014-08-14 14:43   ` Vincent Stehlé
2014-08-26  7:50   ` Luca Ceresoli
2014-08-26  4:19 ` [Buildroot] [PATCH v2 1/2] configs/freescale_imx6dlsabresd: add defconfig for iMX6DL SabreSD Gary Bisson
2014-08-26  7:36   ` Luca Ceresoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FC3913.3060007@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.