From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
Scott Jiang <scott.jiang.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] regmap: Fix handling of volatile registers for format_write() chips
Date: Tue, 26 Aug 2014 17:57:11 +0200 [thread overview]
Message-ID: <53FCAE57.2050103@metafoo.de> (raw)
In-Reply-To: <1409052255-10601-1-git-send-email-broonie@kernel.org>
On 08/26/2014 01:24 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> A previous over-zealous factorisation of code means that we only treat
> registers as volatile if they are readable. For most devices this is fine
> since normally most registers can be read and volatility implies
> readability but for format_write() devices where there is no readback from
> the hardware and we use volatility to mean simply uncacheability this means
> that we end up treating all registers as cacheble.
>
> A bigger refactoring of the code to clarify this is in order but as a fix
> make a minimal change and only check readability when checking volatility
> if there is no format_write() operation defined for the device.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
prev parent reply other threads:[~2014-08-26 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 11:24 [PATCH] regmap: Fix handling of volatile registers for format_write() chips Mark Brown
2014-08-26 15:57 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCAE57.2050103@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.jiang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.