From: Daniel Borkmann <dborkman@redhat.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure
Date: Tue, 26 Aug 2014 18:21:20 +0200 [thread overview]
Message-ID: <53FCB400.70705@redhat.com> (raw)
In-Reply-To: <53FCAF6C.2070401@intel.com>
On 08/26/2014 06:01 PM, Alexander Duyck wrote:
...
> My thought is to just fold ixgbe_maybe_stop_tx into the if statement.
>
> So it shoudl be:
> if (!skb->smit_more || ixgbe_maybe_stop_tx(tx_ring, DESC_NEEDED))
Right, that's better; I was just thinking about the DMA error case,
but in that case we release resources back anyway.
next prev parent reply other threads:[~2014-08-26 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 15:48 [PATCH net-next] ixgbe: flush when in xmit_more mode and under descriptor pressure Daniel Borkmann
2014-08-26 16:01 ` Alexander Duyck
2014-08-26 16:21 ` Daniel Borkmann [this message]
2014-08-26 16:24 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCB400.70705@redhat.com \
--to=dborkman@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.