From: lauraa@codeaurora.org (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 1/2] arm64: Introduce {set,clear}_pte_bit
Date: Tue, 26 Aug 2014 13:15:40 -0700 [thread overview]
Message-ID: <53FCEAEC.2020203@codeaurora.org> (raw)
In-Reply-To: <20140826142707.GF16482@arm.com>
On 8/26/2014 7:27 AM, Catalin Marinas wrote:
> On Tue, Aug 19, 2014 at 08:41:42PM +0100, Laura Abbott wrote:
>> diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h
>> index ffe1ba0..ca41449 100644
>> --- a/arch/arm64/include/asm/pgtable.h
>> +++ b/arch/arm64/include/asm/pgtable.h
>> @@ -149,46 +149,51 @@ extern struct page *empty_zero_page;
>> #define pte_valid_not_user(pte) \
>> ((pte_val(pte) & (PTE_VALID | PTE_USER)) == PTE_VALID)
>>
>> -static inline pte_t pte_wrprotect(pte_t pte)
>> +static pte_t clear_pte_bit(pte_t pte, pgprot_t prot)
>> {
>> - pte_val(pte) &= ~PTE_WRITE;
>> + pte_val(pte) &= ~pgprot_val(prot);
>> return pte;
>> }
>>
>> -static inline pte_t pte_mkwrite(pte_t pte)
>> +static pte_t set_pte_bit(pte_t pte, pgprot_t prot)
>> {
>> - pte_val(pte) |= PTE_WRITE;
>> + pte_val(pte) |= pgprot_val(prot);
>> return pte;
>> }
>
> Why these two functions don't have an "inline"?
>
That's an error on my part.
Will, you mentioned you applied these patches already, how
would you like to fix this up?
Laura
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-26 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 19:41 [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-19 19:41 ` [PATCHv4 1/2] arm64: Introduce {set,clear}_pte_bit Laura Abbott
2014-08-26 14:27 ` Catalin Marinas
2014-08-26 20:15 ` Laura Abbott [this message]
2014-08-27 8:07 ` Will Deacon
2014-09-01 15:42 ` Laura Abbott
2014-08-19 19:41 ` [PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-26 14:40 ` Catalin Marinas
2014-09-01 15:42 ` Laura Abbott
2014-09-01 15:45 ` Will Deacon
2014-09-10 3:58 ` Zi Shen Lim
2014-09-10 8:47 ` Will Deacon
2014-09-11 4:42 ` Laura Abbott
2014-09-11 22:10 ` [PATCH] arm64: pageattr: Correctly adjust unaligned start addresses Laura Abbott
2014-09-12 3:40 ` Z Lim
2014-09-12 15:36 ` Catalin Marinas
2014-08-22 17:36 ` [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCEAEC.2020203@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.