Re: [PATCH] tools/libxl: Initialise both parts of ctx->sigchld_selfpipe[] to -1

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 18/08/2014 14:02, Andrew Cooper wrote:
> Otherwise, if it is not used, libxl_ctx_free() will close fd 0.
>
> Reported-by: Alex Bligh <alex@alex.org.uk>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---

Ping?  This is a rather nasty bug which needs fixing in 4.4 as well.

>  tools/libxl/libxl.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 3526539..a1e0b5e 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -71,6 +71,7 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
>      ctx->childproc_user = 0;
>          
>      ctx->sigchld_selfpipe[0] = -1;
> +    ctx->sigchld_selfpipe[1] = -1;
>      libxl__ev_fd_init(&ctx->sigchld_selfpipe_efd);
>  
>      /* The mutex is special because we can't idempotently destroy it */