Re: [meta-networking][PATCH 1/2] ntp: Disable debugging by default

["Peter A. Bigot" <pab@pabigot.com>]

On 08/13/2014 10:14 PM, rongqing.li@windriver.com wrote:
> From: Xufeng Zhang<xufeng.zhang@windriver.com>
>
> There is a problem in configure.ac file that whether or not
> '--enable-debugging' is specified in configure cmdline, debugging
> is always enabled.

 From my testing this is incorrect.  Both --disable-debugging and 
--enable-debugging=no correctly override the upstream decision to enable 
debugging by default.

> We should disable ntp debugging by default.

Could we have more of an explanation why this is a good thing?  It 
doesn't seem relevant to the security patch it accompanied.

I've got a patch I'm validating that will revert this fix and use 
PACKAGECONFIG to control whether debugging is supported. Personally, I'd 
rather have the default be to keep debugging enabled.

Upstream ntp enables debugging support by default, and OE's build has 
never disabled it before.  ntp is a tricky beast and is very terse about 
what it's doing.  Having the ability to make it explain why (for 
example) it's disabling a reference clock is very useful in 
diagnostics.  Disabling debugging during the build makes it impossible 
to get that information out of an installed system.

Peter

>
> Signed-off-by: Xufeng Zhang<xufeng.zhang@windriver.com>
> ---
>   .../ntp/files/ntp-disable-debugging.patch          |   23 ++++++++++++++++++++
>   meta-networking/recipes-support/ntp/ntp.inc        |    1 +
>   2 files changed, 24 insertions(+)
>   create mode 100644 meta-networking/recipes-support/ntp/files/ntp-disable-debugging.patch
>
> diff --git a/meta-networking/recipes-support/ntp/files/ntp-disable-debugging.patch b/meta-networking/recipes-support/ntp/files/ntp-disable-debugging.patch
> new file mode 100644
> index 0000000..3c94d8d
> --- /dev/null
> +++ b/meta-networking/recipes-support/ntp/files/ntp-disable-debugging.patch
> @@ -0,0 +1,23 @@
> +set ntp_ok to no if ntp debugging is not enabled.
> +
> +Upstream-status: Pending
> +
> +There is a problem in configure.ac file that whether or not
> +'--enable-debugging' is specified in configure cmdline, debugging
> +is always enabled.
> +We should disable ntp debugging by default.
> +
> +Signed-off-by: Xufeng Zhang<xufeng.zhang@windriver.com>
> +
> +---
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -2458,7 +2458,7 @@
> +         [+ include ntpd debugging code]
> +     )],
> +     [ntp_ok=$enableval],
> +-    [ntp_ok=yes]
> ++    [ntp_ok=no]
> + )
> + case "$ntp_ok" in
> +  yes)
> diff --git a/meta-networking/recipes-support/ntp/ntp.inc b/meta-networking/recipes-support/ntp/ntp.inc
> index 49f9901..2c8f488 100644
> --- a/meta-networking/recipes-support/ntp/ntp.inc
> +++ b/meta-networking/recipes-support/ntp/ntp.inc
> @@ -23,6 +23,7 @@ SRC_URI ="http://www.eecis.udel.edu/~ntp/ntp_spool/ntp4/ntp-4.2/ntp-${PV}.tar.g
>              file://sntp.service \
>              file://sntp \
>              file://ntpd.list \
> +           file://ntp-disable-debugging.patch \
>   "
>   
>   inherit autotools update-rc.d useradd systemd