From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] add check parameter to run_tests configuration
Date: Wed, 27 Aug 2014 15:29:35 +0200
Message-ID: <53FDDD3F.8050102@redhat.com>
References: <1409077754-4163-1-git-send-email-chris.j.arges@canonical.com> <1409077754-4163-2-git-send-email-chris.j.arges@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
To: Chris J Arges <chris.j.arges@canonical.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58266 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934364AbaH0N3l (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 27 Aug 2014 09:29:41 -0400
In-Reply-To: <1409077754-4163-2-git-send-email-chris.j.arges@canonical.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 26/08/2014 20:29, Chris J Arges ha scritto:
> +        path=${check_param%%=*}
> +        value=${check_param#*=}
> +        if [ $path ] && [[ $(cat $path) != $value ]]; then

[[ ]] is a bashism, please use [ ].

Also, please include all operands of [ ] within double quotes.

Paolo

> +            echo "skip $1 ($path not equal to $value)"
> +            return
> +        fi