From: Mathias Nyman <mathias.nyman@intel.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci-ring: Fix Null pointer dereference
Date: Wed, 27 Aug 2014 17:25:12 +0300 [thread overview]
Message-ID: <53FDEA48.9030301@intel.com> (raw)
In-Reply-To: <1409068061-10855-1-git-send-email-ricardo.ribalda@gmail.com>
On 08/26/2014 06:47 PM, Ricardo Ribalda Delgado wrote:
> While testing a usb gadget I managed to crash completely the host
> computer. This was due to a NULL pointer derefence.
>
> This patch avoids the crash although the kernel still outputs some
> warnings.
>
> Without this patch, kernels from (at least) 3.14 can be crashed with
> mass storage gadgets.
>
> Affected host: NEC Corporation uPD720200 USB 3.0
>
This should not be necessary anymore after
commit 365038d83313951d6ace15342eb24624bbef1666
xhci: rework cycle bit checking for new dequeue pointers
http://marc.info/?l=linux-usb&m=140844993115671&w=2
Which was just added to Greg's usb-linus branch.
It checks that the new_deq_ptr and new_deq_seg are valid before calling
xhci_queue_new_dequeue_state()
-Mathias
next prev parent reply other threads:[~2014-08-27 14:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 15:47 [PATCH] xhci-ring: Fix Null pointer dereference Ricardo Ribalda Delgado
2014-08-27 14:25 ` Mathias Nyman [this message]
2014-08-27 14:14 ` Ricardo Ribalda Delgado
2014-08-27 15:27 ` Mathias Nyman
2014-08-27 16:10 ` Ricardo Ribalda Delgado
2014-08-28 10:41 ` Mathias Nyman
2014-08-28 10:50 ` Ricardo Ribalda Delgado
2014-08-28 12:36 ` Ricardo Ribalda Delgado
2014-08-28 15:20 ` Mathias Nyman
2014-08-28 15:09 ` Ricardo Ribalda Delgado
2014-08-29 15:20 ` Mathias Nyman
2014-09-01 9:02 ` Ricardo Ribalda Delgado
2014-09-01 9:36 ` Ricardo Ribalda Delgado
2014-09-01 10:37 ` Mathias Nyman
2014-09-01 10:26 ` Ricardo Ribalda Delgado
2014-09-01 11:12 ` Mathias Nyman
2014-09-01 11:19 ` Ricardo Ribalda Delgado
2014-09-01 12:25 ` Mathias Nyman
2014-09-01 12:14 ` Ricardo Ribalda Delgado
2014-09-01 14:16 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDEA48.9030301@intel.com \
--to=mathias.nyman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.