All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>, Gleb Natapov <gleb@kernel.org>,
	Alexander Graf <agraf@suse.de>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	linux-s390 <linux-s390@vger.kernel.org>,
	ben@decadent.org.uk
Subject: Re: [PATCH] KVM: s390/mm: fix up indentation of set_guest_storage_key
Date: Wed, 27 Aug 2014 16:35:21 +0200	[thread overview]
Message-ID: <53FDECA9.1070202@redhat.com> (raw)
In-Reply-To: <1409134802-62477-1-git-send-email-borntraeger@de.ibm.com>

Il 27/08/2014 12:20, Christian Borntraeger ha scritto:
> commit ab3f285f227f ("KVM: s390/mm: try a cow on read only pages for
> key ops")' misaligned a code block. Let's fixup the indentation.
> 
> Reported-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  arch/s390/mm/pgtable.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/s390/mm/pgtable.c b/arch/s390/mm/pgtable.c
> index 5404a62..1570dbd 100644
> --- a/arch/s390/mm/pgtable.c
> +++ b/arch/s390/mm/pgtable.c
> @@ -994,13 +994,13 @@ retry:
>  	}
>  	if (!(pte_val(*ptep) & _PAGE_INVALID) &&
>  	     (pte_val(*ptep) & _PAGE_PROTECT)) {
> -			pte_unmap_unlock(*ptep, ptl);
> -			if (fixup_user_fault(current, mm, addr, FAULT_FLAG_WRITE)) {
> -				up_read(&mm->mmap_sem);
> -				return -EFAULT;
> -			}
> -			goto retry;
> +		pte_unmap_unlock(*ptep, ptl);
> +		if (fixup_user_fault(current, mm, addr, FAULT_FLAG_WRITE)) {
> +			up_read(&mm->mmap_sem);
> +			return -EFAULT;
>  		}
> +		goto retry;
> +	}
>  
>  	new = old = pgste_get_lock(ptep);
>  	pgste_val(new) &= ~(PGSTE_GR_BIT | PGSTE_GC_BIT |
> 

Applying this patch, thanks.

Paolo

      reply	other threads:[~2014-08-27 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 10:20 [PATCH] KVM: s390/mm: fix up indentation of set_guest_storage_key Christian Borntraeger
2014-08-27 14:35 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FDECA9.1070202@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=ben@decadent.org.uk \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=gleb@kernel.org \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.