From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH RFC V8 4/5] xen, libxc: Request page fault injection via libxc Date: Wed, 27 Aug 2014 19:04:07 +0300 Message-ID: <53FE0177.30609@bitdefender.com> References: <1409148101-11703-1-git-send-email-rcojocaru@bitdefender.com> <1409148101-11703-4-git-send-email-rcojocaru@bitdefender.com> <53FE1968020000780002E304@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XMfhq-0001aZ-L3 for xen-devel@lists.xenproject.org; Wed, 27 Aug 2014 16:04:18 +0000 In-Reply-To: <53FE1968020000780002E304@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, tim@xen.org, jun.nakajima@intel.com, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 08/27/2014 06:46 PM, Jan Beulich wrote: >>>> On 27.08.14 at 16:01, wrote: >> --- a/xen/include/asm-x86/hvm/domain.h >> +++ b/xen/include/asm-x86/hvm/domain.h >> @@ -142,6 +142,14 @@ struct hvm_domain { >> */ >> uint64_t sync_tsc; >> >> + /* Memory introspection page fault injection data. */ >> + struct { >> + uint64_t address_space; >> + uint64_t virtual_address; >> + uint32_t errcode; >> + bool_t valid; >> + } fault_info; > > The naming of the field aside I continue to be unconvinced of the > general usefulness of this when being domain rather than vCPU > based. Oh, I've renamed everything else but missed that one, sorry. I'll make sure to rename it and look into a way of maybe making it VCPU-based. Thanks, Razvan Cojocaru