From: "H. Peter Anvin" <hpa@zytor.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, alan@linux.intel.com
Subject: Re: [PATCH 2/2] x86: iosf: Add debugfs support
Date: Wed, 27 Aug 2014 15:20:40 -0700 [thread overview]
Message-ID: <53FE59B8.5080401@zytor.com> (raw)
In-Reply-To: <1409175640-32426-3-git-send-email-david.e.box@linux.intel.com>
On 08/27/2014 02:40 PM, David E. Box wrote:
> Allows access to the iosf sideband through debugfs.
This would break if compiled without CONFIG_DEBUGFS support, which is
often a requirement for security reasons.
Please conditionalize this code, and if practical move it to a separate
.c file.
Most drivers also have separate config options to enable their specific
debugfs options.
-hpa
next prev parent reply other threads:[~2014-08-27 22:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 21:40 [PATCH 0/2] x86: iosf: change Kconfig selection and add debugfs David E. Box
2014-08-27 21:40 ` [PATCH 1/2] x86: iosf: Add Kconfig prompt for IOSF_MBI selection David E. Box
2014-09-02 21:07 ` [tip:x86/platform] x86/iosf: " tip-bot for David E. Box
2014-08-27 21:40 ` [PATCH 2/2] x86: iosf: Add debugfs support David E. Box
2014-08-27 22:20 ` H. Peter Anvin [this message]
2014-09-02 21:07 ` [tip:x86/platform] x86/iosf: " tip-bot for David E. Box
2014-09-17 3:26 ` [PATCH 0/3] x86: iosf: Additions to iosf patch set David E. Box
2014-09-18 5:13 ` [PATCH V2 " David E. Box
2014-09-18 5:13 ` [PATCH V2 1/3] x86: iosf: Add Braswell PCI ID David E. Box
2014-09-19 11:49 ` [tip:x86/platform] x86/platform/intel/iosf: " tip-bot for David E. Box
2014-09-18 5:13 ` [PATCH V2 2/3] x86: iosf: Add better description of IOSF driver in config David E. Box
2014-09-19 11:49 ` [tip:x86/platform] x86/platform/intel/iosf: " tip-bot for David E. Box
2014-09-18 5:13 ` [PATCH V2 3/3] x86: iosf: Add debugfs config option for iosf David E. Box
2014-09-19 11:49 ` [tip:x86/platform] x86/platform/intel/iosf: Add debugfs config option for IOSF tip-bot for David E. Box
2014-09-17 3:26 ` [PATCH 1/3] x86: iosf: Add Braswell PCI ID David E. Box
2014-09-17 3:26 ` [PATCH 2/3] x86: iosf: Move Kconfig to proper submenu David E. Box
2014-09-17 12:31 ` Ingo Molnar
2014-09-17 3:26 ` [PATCH 3/3] x86: iosf: Make debugfs addition a separate config option David E. Box
2014-09-17 12:26 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FE59B8.5080401@zytor.com \
--to=hpa@zytor.com \
--cc=alan@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.