From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v4 01/13] net: dsa: reduce number of protocol hooks Date: Wed, 27 Aug 2014 16:43:41 -0700 Message-ID: <53FE6D2D.4060708@gmail.com> References: <1409028581-17399-1-git-send-email-f.fainelli@gmail.com> <1409028581-17399-2-git-send-email-f.fainelli@gmail.com> <53FDF879.1000504@intel.com> <20140827.162458.878869941352643208.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linville@tuxdriver.com, jhs@mojatatu.com, alexander.duyck@gmail.com To: David Miller , alexander.h.duyck@intel.com Return-path: Received: from mail-pa0-f44.google.com ([209.85.220.44]:57671 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965555AbaH0XoN (ORCPT ); Wed, 27 Aug 2014 19:44:13 -0400 Received: by mail-pa0-f44.google.com with SMTP id rd3so61102pab.3 for ; Wed, 27 Aug 2014 16:44:13 -0700 (PDT) In-Reply-To: <20140827.162458.878869941352643208.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 08/27/2014 04:24 PM, David Miller wrote: > From: Alexander Duyck > Date: Wed, 27 Aug 2014 08:25:45 -0700 > >> Just a thought, you might want to consider using a protocol value other >> than ETH_P_DSA. Maybe we should add a new value named ETH_P_XDSA for >> this approach since what we are doing is a multiplexed DSA protocol now. >> >> This would allow for much easier back-porting of this if needed and also >> prevents us from possibly triggering any issues if there are any >> user-space APIs that might be trying to capture packets based on the >> protocol value. > > Agreed, Florian can you respin this patch set using a newly allocated > ETH_P_* value for these new semantics? Absolutely. While at it, I just realized that ETH_P_BRCMTAG should probably remain within include/net/dsa.h. We don't want that to be exported to user-space since it is used for internal DSA de-multiplexing. Stay tuned! -- Florian