From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH RFC V8 3/5] xen,
 libxc: Force-enable relevant MSR events
Date: Thu, 28 Aug 2014 11:26:37 +0300
Message-ID: <53FEE7BD.8080604@bitdefender.com>
References: <1409148101-11703-1-git-send-email-rcojocaru@bitdefender.com>	<1409148101-11703-3-git-send-email-rcojocaru@bitdefender.com>	<AADFC41AFE54684AB9EE6CBC0274A5D126050126@SHSMSX101.ccr.corp.intel.com>	<53FEDCED.1070904@bitdefender.com>
	<53FF0387020000780002E8C7@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <rcojocaru@bitdefender.com>) id 1XMv28-0006bH-HP
	for xen-devel@lists.xenproject.org; Thu, 28 Aug 2014 08:26:16 +0000
In-Reply-To: <53FF0387020000780002E8C7@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Eddie Dong <eddie.dong@intel.com>, "stefano.stabellini@eu.citrix.com" <stefano.stabellini@eu.citrix.com>, "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "tim@xen.org" <tim@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, "ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>, "ian.campbell@citrix.com" <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/28/2014 11:25 AM, Jan Beulich wrote:
>>>> On 28.08.14 at 09:40, <rcojocaru@bitdefender.com> wrote:
>> On 08/27/2014 11:25 PM, Tian, Kevin wrote:
>>>> From: Razvan Cojocaru [mailto:rcojocaru@bitdefender.com]
>>>> +const u32 vmx_msrs_exit_array[] = {
>>>> +    MSR_IA32_SYSENTER_EIP,
>>>> +    MSR_IA32_SYSENTER_ESP,
>>>> +    MSR_IA32_SYSENTER_CS,
>>>> +    MSR_IA32_MC0_CTL,
>>>> +    MSR_STAR,
>>>> +    MSR_LSTAR
>>>> +};
>>>> +
>>>> +const unsigned int vmx_msrs_exit_array_size =
>>>> +    ARRAY_SIZE(vmx_msrs_exit_array);
>>>> +
>>>
>>> prefer a name including 'force' purpose or at least have a comment
>>> to describe the intention, so its meaning is explained as early as possible.
>>
>> How would vmx_force_enabled_msrs_array (with a comment added) sound to
>> you and Jan?
> 
> vmx_introspection_force_enabled_msrs[]?

No problem, I'll rename it to that.


Thanks,
Razvan Cojocaru