From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMxfJ-0005c0-8N for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMxfE-0006CQ-KB for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:14:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMxfE-0006CD-AN for qemu-devel@nongnu.org; Thu, 28 Aug 2014 07:14:48 -0400 Message-ID: <53FF0F17.1000903@redhat.com> Date: Thu, 28 Aug 2014 05:14:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1409203145-5976-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1409203145-5976-1-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HW5uECLOC4TinF3qB3MugBmBJeFkRMBhS" Subject: Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, weidong.huang@huawei.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HW5uECLOC4TinF3qB3MugBmBJeFkRMBhS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/27/2014 11:19 PM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 In the subject: s/genneric/generic/, s/paring/parsing/ > At present, 'qom-set' only can set string type property, qom-set is typed as taking arbitrary JSON 9one of the few commands with 'gen':'no', which means it is completely type-unsafe, and can therefore accept EVERY type, including JSON integers, not just strings). > which will restrict this qmp command's function. > Using genneric string paring function can handle different Same typos here as in subject. > types, such as int/bool/string etc. >=20 > Signed-off-by: Gonglei > --- --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HW5uECLOC4TinF3qB3MugBmBJeFkRMBhS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT/w8YAAoJEKeha0olJ0NqvBIH/1/ks5a64pfk9nt6J1Wf1uza P0TDwUXBqHS+Yt0nlTtQtZ6TLaKJ3N5CsgFE9V8pToFEJ5P2epBU2qE+eYBZFR7e 5sPzlqAD8Cwaa6hnryzISxSaBdZo6wl9UkD2h+qsi0Hr1vaa9wb1THXEjhdUVaHb yS3Qy1E571pzNiSxMlCEu+mwXG1qxb/lIA6waVEdD1gXmQmbCldMfZn93++N8QdN A/QGo1GfaxjDAtenq0rq8ePCuS1TzshqcQ5T+s91+NUDdPJzHRcjIftvG5B+tO07 cam8w9a/nYe3pIGCFFRCwuHcvTLFK2ljQkfByKYoclIXKV/RcrDpLC1if2MA2Ew= =Hsb7 -----END PGP SIGNATURE----- --HW5uECLOC4TinF3qB3MugBmBJeFkRMBhS--