Re: [meta-oe][for-daisy][PATCH] php: Fix native build due mistakenly linking against host's iconv

[akuster808 <akuster808@gmail.com>]

  Acked-by: Armin Kuster <akuster808@gmail.com>


might have acked the wrong one.



On 08/28/2014 06:54 AM, Otavio Salvador wrote:
> Martin,
>
> On Wed, Aug 27, 2014 at 11:04 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Mon, Aug 25, 2014 at 10:15 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> On Sun, Aug 24, 2014 at 8:36 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> On Sun, Aug 24, 2014 at 2:03 PM, Otavio Salvador
>>>> <otavio@ossystems.com.br> wrote:
>>>>> The configure script has mistakenly choose to enable iconv support,
>>>>> due host to provide it, adding '/usr/lib' to the linking flags and
>>>>> failing as:
>>>>>
>>>>> ,----[ Linking error while testing 'fork' support ]
>>>>> | conftest.c:268: warning: conflicting types for built-in function 'fork'
>>>>> | .../build/tmp/sysroots/x86_64-linux/usr/lib/libxml2.so:
>>>>> |     undefined reference to `gzopen64@ZLIB_1.2.3.3'
>>>>> | collect2: ld returned 1 exit status
>>>>> `----
>>>>>
>>>>> This patch disables iconv support for native builds fixing the error.
>>>>>
>>>>
>>>> the patch subject is confusing. enabling iconv is not mistake but its
>>>> probed and if found its used. in this case libz against which libxml2
>>>> is linked is not used here and that ends up in error.
>>>>
>>>> Can you try to add --with-iconv-dir=${STAGING_LIBDIR_NATIVE}
>>>> and see if it helps ?
>>>
>>> The native does not depends on virtual/iconv. So the natural thing is
>>> to disable it.
>>
>> Hey guys, can you review this one for backporting?
>
> This is the Daisy backport one.
>