From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Thu, 28 Aug 2014 17:26:43 -0400 Subject: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 In-Reply-To: <1409254565-10677-1-git-send-email-dianders@chromium.org> References: <1409254565-10677-1-git-send-email-dianders@chromium.org> Message-ID: <53FF9E93.3040601@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: > These two patches add support for automatically configuring the IO > voltage domains on rk3188 and rk3288 SoCs. The first patch adds some > new notification types to the regulator code. It's used by the second > patch which actually implements the IO voltage domain driver. > > These two patches were co-developed by Heiko St?bner and Doug Anderson > (proof of concept patches were written by Heiko). They were tested in > a private branch on an rk3288 board using rk808 instead of mainline > since rk808 support isn't finalized in mainline yet. > > (sorry if you got this series twice; my mailer seems unhappy with me) > > Heiko St?bner (2): > regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) > soc/rockchip: io-domain: add driver handling io domains > Sorry to shot down but your IO domains are nothing but voltage domains and you should really build something in the drivers/power/* Please have a look at the RFC [1]. You should really go on those lines and collaborate to make a generic voltage domain layer instead of throwing the driver under drivers/soc. > .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ > drivers/regulator/core.c | 63 +++- > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/rockchip/Kconfig | 10 + > drivers/soc/rockchip/Makefile | 1 + > drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ > include/linux/regulator/consumer.h | 20 ++ > 8 files changed, 482 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt > create mode 100644 drivers/soc/rockchip/Kconfig > create mode 100644 drivers/soc/rockchip/Makefile > create mode 100644 drivers/soc/rockchip/io-domain.c > Regards, Santosh [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233819.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Date: Thu, 28 Aug 2014 17:26:43 -0400 Message-ID: <53FF9E93.3040601@ti.com> References: <1409254565-10677-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1409254565-10677-1-git-send-email-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Doug Anderson , Mark Brown , Heiko Stuebner , olof@lixom.net, Arnd Bergmann Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Addy Ke , swarren@nvidia.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, Nishanth Menon , pdeschrijver@nvidia.com, galak@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, sandeep_n@ti.com, agross@codeaurora.org, grant.likely@linaro.org, treding@nvidia.com, Sonny Rao , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gVGh1cnNkYXkgMjggQXVndXN0IDIwMTQgMDM6MzYgUE0sIERvdWcgQW5kZXJzb24gd3JvdGU6 Cj4gVGhlc2UgdHdvIHBhdGNoZXMgYWRkIHN1cHBvcnQgZm9yIGF1dG9tYXRpY2FsbHkgY29uZmln dXJpbmcgdGhlIElPCj4gdm9sdGFnZSBkb21haW5zIG9uIHJrMzE4OCBhbmQgcmszMjg4IFNvQ3Mu ICBUaGUgZmlyc3QgcGF0Y2ggYWRkcyBzb21lCj4gbmV3IG5vdGlmaWNhdGlvbiB0eXBlcyB0byB0 aGUgcmVndWxhdG9yIGNvZGUuICBJdCdzIHVzZWQgYnkgdGhlIHNlY29uZAo+IHBhdGNoIHdoaWNo IGFjdHVhbGx5IGltcGxlbWVudHMgdGhlIElPIHZvbHRhZ2UgZG9tYWluIGRyaXZlci4KPiAKPiBU aGVzZSB0d28gcGF0Y2hlcyB3ZXJlIGNvLWRldmVsb3BlZCBieSBIZWlrbyBTdMO8Ym5lciBhbmQg RG91ZyBBbmRlcnNvbgo+IChwcm9vZiBvZiBjb25jZXB0IHBhdGNoZXMgd2VyZSB3cml0dGVuIGJ5 IEhlaWtvKS4gIFRoZXkgd2VyZSB0ZXN0ZWQgaW4KPiBhIHByaXZhdGUgYnJhbmNoIG9uIGFuIHJr MzI4OCBib2FyZCB1c2luZyByazgwOCBpbnN0ZWFkIG9mIG1haW5saW5lCj4gc2luY2Ugcms4MDgg c3VwcG9ydCBpc24ndCBmaW5hbGl6ZWQgaW4gbWFpbmxpbmUgeWV0Lgo+IAo+IChzb3JyeSBpZiB5 b3UgZ290IHRoaXMgc2VyaWVzIHR3aWNlOyBteSBtYWlsZXIgc2VlbXMgdW5oYXBweSB3aXRoIG1l KQo+IAo+IEhlaWtvIFN0w7xibmVyICgyKToKPiAgIHJlZ3VsYXRvcjogY29yZTogQWRkIFJFR1VM QVRPUl9FVkVOVF9QUkVfVk9MVEFHRV9DSEFOR0UgKGFuZCBBQk9SVCkKPiAgIHNvYy9yb2NrY2hp cDogaW8tZG9tYWluOiBhZGQgZHJpdmVyIGhhbmRsaW5nIGlvIGRvbWFpbnMKPiAKU29ycnkgdG8g c2hvdCBkb3duIGJ1dCB5b3VyIElPIGRvbWFpbnMgYXJlIG5vdGhpbmcgYnV0IHZvbHRhZ2UgZG9t YWlucwphbmQgeW91IHNob3VsZCByZWFsbHkgYnVpbGQgc29tZXRoaW5nIGluIHRoZSBkcml2ZXJz L3Bvd2VyLyoKClBsZWFzZSBoYXZlIGEgbG9vayBhdCB0aGUgUkZDIFsxXS4gWW91IHNob3VsZCBy ZWFsbHkgZ28gb24gdGhvc2UKbGluZXMgYW5kIGNvbGxhYm9yYXRlIHRvIG1ha2UgYSBnZW5lcmlj IHZvbHRhZ2UgZG9tYWluIGxheWVyIGluc3RlYWQgb2YgdGhyb3dpbmcKdGhlIGRyaXZlciB1bmRl ciBkcml2ZXJzL3NvYy4gCgo+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vcm9ja2NoaXAv aW8tZG9tYWluLnR4dCB8ICA2MCArKysrCj4gIGRyaXZlcnMvcmVndWxhdG9yL2NvcmUuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgIDYzICsrKy0KPiAgZHJpdmVycy9zb2MvS2NvbmZpZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+ICBkcml2ZXJzL3NvYy9NYWtl ZmlsZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMSArCj4gIGRyaXZlcnMvc29j L3JvY2tjaGlwL0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgIHwgIDEwICsKPiAgZHJpdmVy cy9zb2Mvcm9ja2NoaXAvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgfCAgIDEgKwo+ICBk cml2ZXJzL3NvYy9yb2NrY2hpcC9pby1kb21haW4uYyAgICAgICAgICAgICAgICAgICB8IDMzMyAr KysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9saW51eC9yZWd1bGF0b3IvY29uc3VtZXIu aCAgICAgICAgICAgICAgICAgfCAgMjAgKysKPiAgOCBmaWxlcyBjaGFuZ2VkLCA0ODIgaW5zZXJ0 aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vcm9ja2NoaXAvaW8tZG9tYWluLnR4dAo+ICBjcmVh dGUgbW9kZSAxMDA2NDQgZHJpdmVycy9zb2Mvcm9ja2NoaXAvS2NvbmZpZwo+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgZHJpdmVycy9zb2Mvcm9ja2NoaXAvTWFrZWZpbGUKPiAgY3JlYXRlIG1vZGUgMTAw NjQ0IGRyaXZlcnMvc29jL3JvY2tjaGlwL2lvLWRvbWFpbi5jCj4gCgpSZWdhcmRzLApTYW50b3No ClsxXSBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9waXBlcm1haWwvbGludXgtYXJtLWtlcm5l bC8yMDE0LUZlYnJ1YXJ5LzIzMzgxOS5odG1sCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbaH1V3j (ORCPT ); Thu, 28 Aug 2014 17:29:39 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:35905 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbaH1V3h (ORCPT ); Thu, 28 Aug 2014 17:29:37 -0400 Message-ID: <53FF9E93.3040601@ti.com> Date: Thu, 28 Aug 2014 17:26:43 -0400 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Doug Anderson , Mark Brown , Heiko Stuebner , , Arnd Bergmann CC: Addy Ke , Sonny Rao , , , , , , , , , , , , , , , , Nishanth Menon Subject: Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 References: <1409254565-10677-1-git-send-email-dianders@chromium.org> In-Reply-To: <1409254565-10677-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote: > These two patches add support for automatically configuring the IO > voltage domains on rk3188 and rk3288 SoCs. The first patch adds some > new notification types to the regulator code. It's used by the second > patch which actually implements the IO voltage domain driver. > > These two patches were co-developed by Heiko Stübner and Doug Anderson > (proof of concept patches were written by Heiko). They were tested in > a private branch on an rk3288 board using rk808 instead of mainline > since rk808 support isn't finalized in mainline yet. > > (sorry if you got this series twice; my mailer seems unhappy with me) > > Heiko Stübner (2): > regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) > soc/rockchip: io-domain: add driver handling io domains > Sorry to shot down but your IO domains are nothing but voltage domains and you should really build something in the drivers/power/* Please have a look at the RFC [1]. You should really go on those lines and collaborate to make a generic voltage domain layer instead of throwing the driver under drivers/soc. > .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++ > drivers/regulator/core.c | 63 +++- > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/rockchip/Kconfig | 10 + > drivers/soc/rockchip/Makefile | 1 + > drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++ > include/linux/regulator/consumer.h | 20 ++ > 8 files changed, 482 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt > create mode 100644 drivers/soc/rockchip/Kconfig > create mode 100644 drivers/soc/rockchip/Makefile > create mode 100644 drivers/soc/rockchip/io-domain.c > Regards, Santosh [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233819.html