All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] systemtap: Patches for version 2.1
Date: Thu, 28 Aug 2014 17:14:26 -0700	[thread overview]
Message-ID: <53FFC5E2.3010207@linux.intel.com> (raw)
In-Reply-To: <1409221406-25014-1-git-send-email-muzaffar_mahmood@mentor.com>

On 08/28/2014 03:23 AM, Muzaffar Mahmood wrote:
> From: Mikhail Durnev <Mikhail_Durnev@mentor.com>
>
Please tell us why?  If you up-revving, does it make more sense to 
change where we are pointing the git hash?

> Signed-off-by: Mikhail Durnev <mikhail_durnev@mentor.com>
> Signed-off-by: Muzaffar Mahmood <muzaffar_mahmood@mentor.com>
> ---
>   .../systemtap/systemtap/system_map_location.patch  |   13 +++++++++++++
>   meta/recipes-kernel/systemtap/systemtap_git.inc    |    1 +
>   2 files changed, 14 insertions(+)
>   create mode 100644 meta/recipes-kernel/systemtap/systemtap/system_map_location.patch
>
> diff --git a/meta/recipes-kernel/systemtap/systemtap/system_map_location.patch b/meta/recipes-kernel/systemtap/systemtap/system_map_location.patch
> new file mode 100644
> index 0000000..cd4f19e
> --- /dev/null
> +++ b/meta/recipes-kernel/systemtap/systemtap/system_map_location.patch

As with the other patch, this patch file is missing Upstream-Status and 
Signed-off-by.

See the http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks
	Sau!

> @@ -0,0 +1,13 @@
> +Index: git/session.cxx
> +===================================================================
> +--- git.orig/session.cxx
> ++++ git/session.cxx
> +@@ -1634,7 +1634,7 @@ systemtap_session::parse_kernel_function
> + 	clog << _F("Kernel symbol table %s unavailable, (%s)",
> + 		   system_map_path.c_str(), strerror(errno)) << endl;
> +
> +-      system_map_path = "/boot/System.map-" + kernel_release;
> ++      system_map_path = kernel_build_tree + "/System.map-" + kernel_release;
> +       system_map.clear();
> +       system_map.open(system_map_path.c_str(), ifstream::in);
> +       if (! system_map.is_open())
> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
> index 3e1e80a..33aa136 100644
> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> @@ -6,6 +6,7 @@ PV = "2.5+git${SRCPV}"
>   SRC_URI = "git://sourceware.org/git/systemtap.git \
>              file://docproc-build-fix.patch \
>              file://obsolete_automake_macros.patch \
> +           file://system_map_location.patch \
>              file://tapset-linux-sendfile-syscall.patch \
>             "
>
>


      reply	other threads:[~2014-08-29  0:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28 10:23 [PATCH] systemtap: Patches for version 2.1 Muzaffar Mahmood
2014-08-29  0:14 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FFC5E2.3010207@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=muzaffar_mahmood@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.