From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDE8C433F5 for ; Wed, 6 Oct 2021 14:24:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CC2F611AE for ; Wed, 6 Oct 2021 14:24:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5CC2F611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ZdzHU/5Hj5TjXZfTb0lxlPZ0IE6mlKN+51xkd/xa3nw=; b=ENu4OserS2WhaFsu9Ug5bmn1UC oWJismuvX7SA2C5ffS8+Af1VB+MFL2rnAyWU7IvBBFrXVtdsydSMozrn7FJJ775MkAeZ2RxIPXeWg FrY4Xb5qjiUxicc3XxSxCNWRkX7rggBS9RUM55kFH04T0yv0heHTJNAOLnYjl5JCxncdklL0QpJ0W Ybq5qlcs4fr+8EvV/Me6dHObY4kmFoWqyDz5+Z2TdigwB2Cq4gtumM1td/Ixx6U3XRFessl9GB2le 9TElQykEYRICNfuJjXW721RbkLNcXm2zSfJLXvcJkrGuC9D6rvTI25obOFNjjyRh+ic4xd+j1LywC XLEInCCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7oU-00EcXa-UC; Wed, 06 Oct 2021 14:22:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7oQ-00EcWn-HS for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 14:22:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18B136D; Wed, 6 Oct 2021 07:22:24 -0700 (PDT) Received: from [10.57.43.152] (unknown [10.57.43.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 012703F66F; Wed, 6 Oct 2021 07:22:20 -0700 (PDT) Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter To: Marco Elver Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi References: <20211004202253.27857-1-vincenzo.frascino@arm.com> <20211004202253.27857-6-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <53a2d27a-57f7-a5c8-d8d0-17c78d95decd@arm.com> Date: Wed, 6 Oct 2021 16:22:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_072226_662794_C2D25FAC X-CRM114-Status: GOOD ( 10.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/6/21 1:35 PM, Marco Elver wrote: >> +static inline bool kasan_sync_fault_possible(void) >> +{ >> + return !kasan_flag_async | kasan_flag_asymm; >> } > Is the choice of bit-wise OR a typo? Because this should probably have > been logical OR. In this case, functionally it shouldn't matter, but is > unusual style. Good catch! This is clearly a typo and a copy-paste of a typo ;) -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02161C433FE for ; Wed, 6 Oct 2021 14:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6182610A1 for ; Wed, 6 Oct 2021 14:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238643AbhJFOYR (ORCPT ); Wed, 6 Oct 2021 10:24:17 -0400 Received: from foss.arm.com ([217.140.110.172]:56704 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbhJFOYQ (ORCPT ); Wed, 6 Oct 2021 10:24:16 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 18B136D; Wed, 6 Oct 2021 07:22:24 -0700 (PDT) Received: from [10.57.43.152] (unknown [10.57.43.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 012703F66F; Wed, 6 Oct 2021 07:22:20 -0700 (PDT) Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter To: Marco Elver Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi References: <20211004202253.27857-1-vincenzo.frascino@arm.com> <20211004202253.27857-6-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: <53a2d27a-57f7-a5c8-d8d0-17c78d95decd@arm.com> Date: Wed, 6 Oct 2021 16:22:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/21 1:35 PM, Marco Elver wrote: >> +static inline bool kasan_sync_fault_possible(void) >> +{ >> + return !kasan_flag_async | kasan_flag_asymm; >> } > Is the choice of bit-wise OR a typo? Because this should probably have > been logical OR. In this case, functionally it shouldn't matter, but is > unusual style. Good catch! This is clearly a typo and a copy-paste of a typo ;) -- Regards, Vincenzo