From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1esndX-0000wW-Tj for ath10k@lists.infradead.org; Mon, 05 Mar 2018 10:46:37 +0000 MIME-Version: 1.0 Date: Mon, 05 Mar 2018 16:16:21 +0530 From: akolli@codeaurora.org Subject: Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters In-Reply-To: <1974303.3lPsqGCgIZ@bentobox> References: <1520233148-26050-1-git-send-email-akolli@codeaurora.org> <1520233148-26050-3-git-send-email-akolli@codeaurora.org> <1974303.3lPsqGCgIZ@bentobox> Message-ID: <53a3580c002d7af01668f4716aae56bd@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sven Eckelmann Cc: Sathishkumar Muruganandam , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOC0wMy0wNSAxMzoxMiwgU3ZlbiBFY2tlbG1hbm4gd3JvdGU6Cj4gT24gTW9udGFnLCA1 LiBNw6RyeiAyMDE4IDEyOjI5OjA4IENFVCBBbmlsa3VtYXIgS29sbGkgd3JvdGU6Cj4+IEBAIC00 OTYsNiArNDk3LDggQEAgc3RydWN0IGF0aDEwa19kZWJ1ZyB7Cj4+ICAgICAgICAgdTMyIHJlZ19h ZGRyOwo+PiAgICAgICAgIHUzMiBuZl9jYWxfcGVyaW9kOwo+PiAgICAgICAgIHZvaWQgKmNhbF9k YXRhOwo+PiArICAgICAgIHUzMiBmd190ZXN0X3BhcmFtX2lkOwo+PiArICAgICAgIHUzMiBmd190 ZXN0X3BhcmFtX3ZhbHVlOwo+PiAgfTsKPiAKPiBXaHkgaXMgaXQgbmVjZXNzYXJ5IHRvIGhhdmUg dGhlc2UgdHdvIHZhbHVlcyBpbiBhdGgxMGtfZGVidWc/IFRoZXkgc2VlbSAKPiB0byBiZQo+IHVz ZWQgb25seSBpbiB0aGUgY29udGV4dCBvZiBhdGgxMGtfd3JpdGVfZndfdGVzdCgpLgo+IApZZXMu IGl0IGlzIG5vdCByZXVzZWQsIHdpbGwgcmVtb3ZlIHRoaXMuCgo+IFdoZXJlIGNhbiB3ZSBmaW5k IHRoZSBkb2N1bWVudGF0aW9uIG9mIHRoZSBwb3NzaWJsZSBwYXJhbV9pZCBhbmQgCj4gcGFyYW1f dmFsdWVzPwo+IApBbGwgdGhlc2UgcGFyYW1ldGVycyBhcmUgZm9yIGV4cGVyaW1lbnRhdGlvbiBw dXJwb3NlLgoKVGhhbmtzLApBbmlsLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46976 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933135AbeCEKqW (ORCPT ); Mon, 5 Mar 2018 05:46:22 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Mon, 05 Mar 2018 16:16:21 +0530 From: akolli@codeaurora.org To: Sven Eckelmann Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Sathishkumar Muruganandam Subject: Re: [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters In-Reply-To: <1974303.3lPsqGCgIZ@bentobox> References: <1520233148-26050-1-git-send-email-akolli@codeaurora.org> <1520233148-26050-3-git-send-email-akolli@codeaurora.org> <1974303.3lPsqGCgIZ@bentobox> Message-ID: <53a3580c002d7af01668f4716aae56bd@codeaurora.org> (sfid-20180305_114625_675887_91142D90) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-03-05 13:12, Sven Eckelmann wrote: > On Montag, 5. März 2018 12:29:08 CET Anilkumar Kolli wrote: >> @@ -496,6 +497,8 @@ struct ath10k_debug { >> u32 reg_addr; >> u32 nf_cal_period; >> void *cal_data; >> + u32 fw_test_param_id; >> + u32 fw_test_param_value; >> }; > > Why is it necessary to have these two values in ath10k_debug? They seem > to be > used only in the context of ath10k_write_fw_test(). > Yes. it is not reused, will remove this. > Where can we find the documentation of the possible param_id and > param_values? > All these parameters are for experimentation purpose. Thanks, Anil.