From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0C09EB64D9 for ; Thu, 6 Jul 2023 07:51:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHJlh-00006Q-Gd; Thu, 06 Jul 2023 03:51:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHJlc-0008WA-Tb; Thu, 06 Jul 2023 03:51:09 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3] helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHJlZ-0003ss-Pu; Thu, 06 Jul 2023 03:51:08 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4QxTH73zj4z4wxR; Thu, 6 Jul 2023 17:50:59 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QxTH43T4Vz4wZw; Thu, 6 Jul 2023 17:50:56 +1000 (AEST) Message-ID: <53ae3355-e7a9-13cb-92d7-b300f44951f1@kaod.org> Date: Thu, 6 Jul 2023 09:50:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] target/ppc: Machine check on invalid real address access on POWER9/10 Content-Language: en-US To: Nicholas Piggin , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Daniel Henrique Barboza , David Gibson , Greg Kurz , Harsh Prateek Bora References: <20230703120301.45313-1-npiggin@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=SRS0=00IJ=CY=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.089, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/6/23 09:32, Nicholas Piggin wrote: > On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote: >> ppc currently silently accepts invalid real address access. Catch >> these and turn them into machine checks on POWER9/10 machines. > > Would there be any objections to merging this and the checkstop patch? > We could disable this one before release if it turns out to cause > breakage. > > I don't think it needs to rebase, and passes clang build and make check > here. Just messed up the separator on the changelog of the checkstop > patch. I have been using the v2 series for a while : https://patchwork.ozlabs.org/project/qemu-ppc/list/?series=361456 without patch 4 and it looked good. Let's take v3 since this patch is unchanged. Thanks, C. > Thanks, > Nick > > >> >> Signed-off-by: Nicholas Piggin >> --- >> Since v1: >> - Only implement this for POWER9/10. Seems like previous IBM processors >> may not catch this, trying to get info. >> >> Since v2: >> - Split out from larger series since it is independent.