From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC6DF28D8D0 for ; Fri, 4 Sep 2026 08:03:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788508987; cv=none; b=lrhVV3zDCuFoOZW2/L1PUqNV/Snlktksz3Et8MC5iZpm5brNzkNHwcpWlJrppk8s4/8t0ysbJLFk+R7qowzrWjwWuRHxsxap+UmP77bT3jppf3W02dIt0RduZ+Gz5Ikk8MEh7QaMVzlYE4pAqnu4vpeNkBBc7tICWd14Zpdwgx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788508987; c=relaxed/simple; bh=/JxoYyZw8rvXwU7G/U87fprDVpjKUZ0WgJD9uCb5TZk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Bnw3oIZ3Ov1cbAZdmHtEPdkU75NV9Rw8XCfQ+o3G9snV7uJDkoGrsMSnky4wVlrKC7wurAOBDgd23MZ0GqozC4+V2Zcl3ZLiUh9C0Eye1MGScVoIvNeA8kVzPBcQpLnkvD6IOgwHUVTWOZ5DNLEUcVNjwgoo1bkZHUyeEbbPzNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QoNwALlq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U/kj58Mi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QoNwALlq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U/kj58Mi" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6847mnlD4111308 for ; Fri, 4 Sep 2026 08:03:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eSPnEJt/utJLJrcQDxoCun9VKVut8jjz7U4CayigJTo=; b=QoNwALlqKiwEJowk Wz60dx7FmUxaSQvGYxtVxsFkKtHK3FVHGWifqXW8aTQ4XOSCZQHAqI9E16vtbf79 FQxva20Rj3BPwoA1cbbdSDEKHHlmGVR7Cxd+5ouIK4fWA9tmMbO9K/zCd6OFCCKh BEd9z0wGbwX2fqBByT7edi6CapE7KEDZKwRtHRlMYoYxGxg77Rk/bgkcvU5qSy0X kB8Rsel0koS3cbYyU/H/X4OZwPwGaTJqnb40qzlqZSpyRLz9VsebjvPHdHO7Q083 2We48NFHcTV9qG7lqrnCCujks1BdKlL9hn2T8sZ+3FmN/stx3ZB0hlqznabB8Hm8 2eZt5Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf9b1c7s6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 04 Sep 2026 08:03:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e661ce1dcso13212785a.0 for ; Fri, 04 Sep 2026 01:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788508984; x=1789113784; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eSPnEJt/utJLJrcQDxoCun9VKVut8jjz7U4CayigJTo=; b=U/kj58Mi3iifLfPN1c6AHCY1oL6Q3HejLzY/swzjdpWRgMkHMXIvMEsyCW1Ctm4kZ1 nqZGKDG8P0oapYfhqicIUYY4fKRq5VSlOAr3US3PJifPs/IiUuBB5aidTnjXbqV2bcCu tDjOLkAp0WATHQmCrl90t4Ehv0EwrXezlKSLpmRW21NKU8ipILdpbzmtbTTzq8UlCpa/ InWTUR9cwv3KOd7jDmrJQ4okDjNt4kr13xKDdloEH69t9EyOVAR/6uG12S7evRQDhMlW At1eLzcxnDY/zqzvMcGmDlCg+GjWeI6uDwZqBHj1C+son6RxWQsPaKUW47z4pB8aAQNw FLDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788508984; x=1789113784; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eSPnEJt/utJLJrcQDxoCun9VKVut8jjz7U4CayigJTo=; b=H2lS5XVDBu+J22lC0yxntTRh0bixXKmntCQZkQWRK73ySufhDBrvKX11OA6bA9OCJ/ cBlfxh0XQXn8Qa3qRWGMNjqAlk0+nPln2tK08AAwtq1ZWylB+3u7j1FQxyst/ZUYUFkY pQ4ytA2C/3hZKmzW/y9qmeijPxW3c1yIesx300IbqeCKWuhYNriB9f57BYOAavTsQ7mD k9ex8h08LDtDkfe6WPXDx36YfVZpGa4ElrZBfhdaw4CNf5+dY7vMTV1Y515P2sqgFKF0 JgQJx41bmzpPh77Se9Bq6Lx2Jxv/Gnr94zsqZI5//vspgx21UFWSu8EW3IKrW8bIwCzS 6VYA== X-Gm-Message-State: AFuF++mTJ4oIgfmjXBI0yaft3YJjq6p/KhlORBEswYCYxUHMauCKYEUC u4FcIgylJvzVD7LbKtKKUMH9k59lpEfcM1nu23hrQ9F0tVRQ6Axl72ljrRi2Ka6rfIPomuEea1w p4PwGTXC53rqrAAAPLYz1WsUyV9BOPIeLl2gGTkSmY+UXtdG6yocR6/0yjfZIsb1PlcsN X-Gm-Gg: AYBFou0jPFYpLNB78BXLk3I79WqdQySTYoNq33kCS7pTbFMzINIAb8SX1dVOnqP0cH/ N1xS9HbcAc4vmPhtQvEW+I7wnB+jBwBSRu8+sA8LDJqxTFSwZRBaprC/gEDCF8bct2/aFnD8bo8 OfCTg92QqaFp8c3hBdS1o6jFNfEWg3v3yFu0vHdnJsojLcg4CDTERy+Lu5g4z/tLwaUnMuB2q96 7AXOM2BfHThw+HxGu38J0Nlu9lc6RP+r9MWLFxLC752Ao62pgnyww64FyzK8Xxicxmdin7+Fe8b YXDW6O+cMVdkWw+7JBHNXUhxQ25lxK+dgrCFGxSTgq4zJJC/Ejla5k46g6bGPbhdOEFgS6XneHN Qp510jR0WTON8iaqMEPDY1g== X-Received: by 2002:a05:620a:4444:b0:939:6c63:a7da with SMTP id af79cd13be357-93980358fe1mr312045385a.0.1788508983621; Fri, 04 Sep 2026 01:03:03 -0700 (PDT) X-Received: by 2002:a05:620a:4444:b0:939:6c63:a7da with SMTP id af79cd13be357-93980358fe1mr312040985a.0.1788508982948; Fri, 04 Sep 2026 01:03:02 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c260d4aa0c7sm69797766b.20.2026.09.04.01.03.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2026 01:03:01 -0700 (PDT) Message-ID: <53b0b91c-6ca6-48a5-b93c-ca2ae9680ad0@oss.qualcomm.com> Date: Fri, 4 Sep 2026 10:03:00 +0200 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tty: serial: qcom_geni: don't ida_free() the console port line From: Konrad Dybcio To: Neil Armstrong , Greg Kroah-Hartman , Jiri Slaby , Viken Dadhaniya Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20260904-topic-sm8x50-upstream-tty-serial-geni-fix-ida-free-v1-1-02e18c31aeba@linaro.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: pOtWj2Q8c083wMPJ_hvsxM4yj8dVrSlm X-Proofpoint-Spam-Info: AW1haW4tMjYwOTA0MDA3MyBTYWx0ZWRfX7lEduxdyC6qC +y1iVxRCwLE8LwWJkr6XV78oT/SBwYnWV5AMacxvis1nvrYPibmGFwjAbF468MCVJczG5BP3HMX BkEaHOj76WyZcjdIMfZi6UO7sJx3UCk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTA0MDA3MyBTYWx0ZWRfX3E8nUYxLmN62 5H8liOBEdiC0ZWC1vOPB9OCA1eUxGwf1eWrc+kSutO81/AWGbk0dFJH0f/+MNPEnbdZoWTHeZOV uFSjzrdkm+I9xps6Xtka1XNFLR0bl3U8I+m7Em7Uqo9dIKUFY8G8VvL0X5tinpGdU/uEJDGzD56 hfmzBvW7Ou6UF2WZoKprcw3lE69YQR9T5lIufauUc8HuvwJyvghiypPtzC0fjoYovJ767bG6RHS /glGyhSrvq+JfHwp3VsQdhfkYKs1SPm4lpTayuTZcADB0IRxOPTi7N7t3rHkLKJMLnvuwNWp2JX YgRp7KtBnSS2jbbJrpe6TB1ywoKDFyJy/w7xPr/ICMQgcAjX3Eg/yyZjpgrt7n5ojTPKngfAWIV gdXMIJMvHJN8ngMbM/bN2Ids1NPFL+IHQfv/jxTBmENNGIBfDq7Xrv86VS+5/1mgzmCMxDDUMhy RFTxUjhQF5uHZSGHc3A== X-Authority-Analysis: v=2.4 cv=NNTlPU6g c=1 sm=1 tr=0 ts=6a9a7b38 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=oCYrDJX_Fzh7Vr1zKUEA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: pOtWj2Q8c083wMPJ_hvsxM4yj8dVrSlm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-04_02,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609040073 On 9/4/26 10:02 AM, Konrad Dybcio wrote: > On 9/4/26 9:09 AM, Neil Armstrong wrote: >> The console port (qcom_geni_console_port) is a static instance whose >> uport.line is hardcoded to 0 and is never allocated from port_ida. >> Only the non-console path in get_port_from_line() calls ida_alloc_range(). >> >> Fix the qcom_geni_serial_remove() and the matching probe() error path >> so unbinding the console device doesn't hit: >> >> WARNING: ida_free called for id=0 which is not allocated >> >> qcom_geni_serial_remove+0x58/0x80 >> >> Fixes: a53be6945f51 ("serial: qcom-geni: Remove alias dependency from qcom serial driver") >> Signed-off-by: Neil Armstrong >> --- > > >> drivers/tty/serial/qcom_geni_serial.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index 3633723acef8..bdbdfd7dfaac 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -1979,7 +1979,8 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) >> port->wakeup_irq); >> if (ret) { >> device_init_wakeup(&pdev->dev, false); >> - ida_free(&port_ida, uport->line); >> + if (!uart_console(uport)) >> + ida_free(&port_ida, uport->line); > > GPT points out this will always return false before uart_add_one_port() > is called You can use if (data->console) instead Konrad