From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCGIa-0001bN-Tt for kexec@lists.infradead.org; Tue, 16 Oct 2018 03:45:38 +0000 Subject: Re: [PATCH 0/3 v3] add reserved e820 ranges to the kdump kernel e820 table References: <20180921073211.20097-1-lijiang@redhat.com> <20181016025657.GB13006@dhcp-128-65.nay.redhat.com> From: lijiang Message-ID: <53b582bd-e30a-848a-dfcd-e79e51296598@redhat.com> Date: Tue, 16 Oct 2018 11:45:06 +0800 MIME-Version: 1.0 In-Reply-To: <20181016025657.GB13006@dhcp-128-65.nay.redhat.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com, bhe@redhat.com, tiwai@suse.de, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, bp@suse.de, akpm@linux-foundation.org, dan.j.williams@intel.com 5ZyoIDIwMTjlubQxMOaciDE25pelIDEwOjU2LCBEYXZlIFlvdW5nIOWGmemBkzoKPiBPbiAwOS8y MS8xOCBhdCAwMzozMnBtLCBMaWFuYm8gSmlhbmcgd3JvdGU6Cj4+IEU4MjAgcmVzZXJ2ZWQgcmFu Z2VzIGlzIHVzZWZ1bCBpbiBrZHVtcCBrZXJuZWwsIHdlIGhhdmUgYWRkZWQgdGhpcyBpbgo+PiBr ZXhlYy10b29scyBjb2RlLgo+Pgo+PiBPbmUgcmVhc29uIGlzIFBDSSBtbWNvbmYgKGV4dGVuZGVk IG1vZGUpIHJlcXVpcmVzIHJlc2VydmVkIHJlZ2lvbiBvdGhlcndpc2UKPj4gaXQgZmFsbHMgYmFj ayB0byBsZWdhY3kgbW9kZS4KPj4KPj4gRnVydGhlcm1vcmUsIHdoZW4gQU1EIFNNRSBrZHVtcCBz dXBwb3J0LCBpdCBuZWVkcyB0byBtYXAgZG1pIHRhYmxlIGFyZWEgYXMKPj4gdW5lbmNyeXB0ZWQu IEZvciBub3JtYWwgYm9vdCwgdGhlc2UgcmFuZ2VzIHNpdCBpbiBlODIwIHJlc2VydmVkIHJhbmdl cywKPj4gdGh1cyB0aGUgZWFybHkgaW9yZW1hcCBjb2RlIG5hdHVyYWxseSBtYXAgdGhlbSBhcyB1 bmVuY3J5cHRlZC4gSWYgd2UgYWxzbwo+PiBoYXZlIHNhbWUgZTgyMCByZXNlcnZlIHNldHVwIGlu IGtkdW1wIGtlcm5lbCB0aGVuIGl0IHdpbGwganVzdCB3b3JrIGxpa2UKPj4gbm9ybWFsIGtlcm5l bC4KPj4KPj4gS2R1bXAgdXNlcyB3YWxrX2lvbWVtX3Jlc19kZXNjIHRvIGl0ZXJhdGUgcmVzb3Vy Y2VzLCB0aGVuIGFkZHMgbWF0Y2hlZCBkZXNjCj4+IHRvIGU4MjAgdGFibGUgZm9yIHRoZSBrZHVt cCBrZXJuZWwuCj4+Cj4+IEJ1dCBJT1JFU19ERVNDX05PTkUgcmVzb3VyY2UgdHlwZSBpbmNsdWRl cyBzZXZlcmFsIGRpZmZlcmVudCBlODIwIHR5cGVzLCB3ZQo+PiBuZWVkIGFkZCBleGFjdCBlODIw IHR5cGUgdG8gdGhlIGtkdW1wIGtlcm5lbCBlODIwIHRhYmxlLCB0aHVzIGl0IGFsc28gbmVlZHMK Pj4gYW4gZXh0cmEgY2hlY2tpbmcgaW4gbWVtbWFwX2VudHJ5X2NhbGxiYWNrKCkgdG8gbWF0Y2gg dGhlIGU4MjAgdHlwZSBhbmQKPj4gcmVzb3VyY2UgbmFtZS4KPj4KPj4gQnkgdGhlIHdheSwgd2Ug YWxzbyBmaXggYW4gZXJyb3Igd2hpY2ggd2Fsa3MgdGhyb3VnaCBpb21lbSByZXNvdXJjZXMsIHRo ZQo+PiB2YWx1ZXMgb2YgdGhlIGZ1bmN0aW9uIHBhcmFtZXRlciBtYXkgYmUgbW9kaWZpZWQgaW4g dGhlIHdoaWxlIGxvb3Agb2YKPj4gX193YWxrX2lvbWVtX3Jlc19kZXNjKCksIHdoaWNoIHdpbGwg Y2F1c2UgdXMgdG8gbm90IGdldCB0aGUgZGVzaXJlZCByZXN1bHQKPj4gaW4gc29tZSBjYXNlcy4K Pj4KPj4gQ2hhbmdlcyBzaW5jZSB2MjoKPj4gMS4gTW9kaWZpZWQgdGhlIHZhbHVlIG9mIGZsYWdz IHRvICIwIiwgd2hlbiB3YWxraW5nIHRocm91Z2ggdGhlIHdob2xlCj4+IHRyZWUgZm9yIGU4MjAg cmVzZXJ2ZWQgcmFuZ2VzLgo+PiAyLiBNb2RpZmllZCB0aGUgaW52YWxpZCBTT0IgY2hhaW4gaXNz dWUuCj4+Cj4+IExpYW5ibyBKaWFuZyAoMyk6Cj4+ICAgcmVzb3VyY2U6IGZpeCBhbiBlcnJvciB3 aGljaCB3YWxrcyB0aHJvdWdoIGlvbWVtIHJlc291cmNlcwo+PiAgIHg4Ni9rZXhlY19maWxlOiBh ZGQgZTgyMCBlbnRyeSBpbiBjYXNlIGU4MjAgdHlwZSBzdHJpbmcgbWF0Y2hlcyB0byBpbwo+PiAg ICAgcmVzb3VyY2UgbmFtZQo+PiAgIHg4Ni9rZXhlY19maWxlOiBhZGQgcmVzZXJ2ZWQgZTgyMCBy YW5nZXMgdG8ga2R1bXAga2VybmVsIGU4MjAgdGFibGUKPiAKPiBMaWFuYm8sIHNpbmNlIEJqb3Ju IGhhcyBmaXhlZCB0aGUgcmVzb3VyY2UgaXNzdWUgaW4gYW5vdGhlciBwYXRjaHNldCwKPiBjYW4g eW91IHJlYmFzZSB5b3VyIHBhdGNoIDIgYW5kIDMgb24gdG9wIG9mIGhpcyBwYXRjaGVzIGFuZCBy ZXNlbmQ/Cj4gCk9rLCBUaGFua3MgZm9yIHlvdXIgcmVtaW5kZXIuCkkgd2lsbCBhZGp1c3QgdGhl c2UgcGF0Y2hlcyBhbmQgcG9zdCBhZ2Fpbi4KClRoYW5rcy4KTGlhbmJvCj4+Cj4+ICBhcmNoL3g4 Ni9pbmNsdWRlL2FzbS9lODIwL2FwaS5oIHwgIDIgKysKPj4gIGFyY2gveDg2L2tlcm5lbC9jcmFz aC5jICAgICAgICAgfCAxMSArKysrKysrKysrLQo+PiAgYXJjaC94ODYva2VybmVsL2U4MjAuYyAg ICAgICAgICB8ICAyICstCj4+ICBrZXJuZWwvcmVzb3VyY2UuYyAgICAgICAgICAgICAgIHwgIDMg KysrCj4+ICA0IGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p Cj4+Cj4+IC0tIAo+PiAyLjE3LjEKPj4KPiAKPiBUaGFua3MKPiBEYXZlCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QK a2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B6DBC04EBD for ; Tue, 16 Oct 2018 03:45:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C145205C9 for ; Tue, 16 Oct 2018 03:45:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C145205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbeJPLdn (ORCPT ); Tue, 16 Oct 2018 07:33:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36967 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727213AbeJPLdn (ORCPT ); Tue, 16 Oct 2018 07:33:43 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB70028A5E; Tue, 16 Oct 2018 03:45:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-106.pek2.redhat.com [10.72.12.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 807998A0F2; Tue, 16 Oct 2018 03:45:12 +0000 (UTC) Subject: Re: [PATCH 0/3 v3] add reserved e820 ranges to the kdump kernel e820 table To: Dave Young Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org, dan.j.williams@intel.com, thomas.lendacky@amd.com, bhelgaas@google.com, baiyaowei@cmss.chinamobile.com, tiwai@suse.de, bp@suse.de, brijesh.singh@amd.com, bhe@redhat.com References: <20180921073211.20097-1-lijiang@redhat.com> <20181016025657.GB13006@dhcp-128-65.nay.redhat.com> From: lijiang Message-ID: <53b582bd-e30a-848a-dfcd-e79e51296598@redhat.com> Date: Tue, 16 Oct 2018 11:45:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181016025657.GB13006@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 16 Oct 2018 03:45:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2018年10月16日 10:56, Dave Young 写道: > On 09/21/18 at 03:32pm, Lianbo Jiang wrote: >> E820 reserved ranges is useful in kdump kernel, we have added this in >> kexec-tools code. >> >> One reason is PCI mmconf (extended mode) requires reserved region otherwise >> it falls back to legacy mode. >> >> Furthermore, when AMD SME kdump support, it needs to map dmi table area as >> unencrypted. For normal boot, these ranges sit in e820 reserved ranges, >> thus the early ioremap code naturally map them as unencrypted. If we also >> have same e820 reserve setup in kdump kernel then it will just work like >> normal kernel. >> >> Kdump uses walk_iomem_res_desc to iterate resources, then adds matched desc >> to e820 table for the kdump kernel. >> >> But IORES_DESC_NONE resource type includes several different e820 types, we >> need add exact e820 type to the kdump kernel e820 table, thus it also needs >> an extra checking in memmap_entry_callback() to match the e820 type and >> resource name. >> >> By the way, we also fix an error which walks through iomem resources, the >> values of the function parameter may be modified in the while loop of >> __walk_iomem_res_desc(), which will cause us to not get the desired result >> in some cases. >> >> Changes since v2: >> 1. Modified the value of flags to "0", when walking through the whole >> tree for e820 reserved ranges. >> 2. Modified the invalid SOB chain issue. >> >> Lianbo Jiang (3): >> resource: fix an error which walks through iomem resources >> x86/kexec_file: add e820 entry in case e820 type string matches to io >> resource name >> x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table > > Lianbo, since Bjorn has fixed the resource issue in another patchset, > can you rebase your patch 2 and 3 on top of his patches and resend? > Ok, Thanks for your reminder. I will adjust these patches and post again. Thanks. Lianbo >> >> arch/x86/include/asm/e820/api.h | 2 ++ >> arch/x86/kernel/crash.c | 11 ++++++++++- >> arch/x86/kernel/e820.c | 2 +- >> kernel/resource.c | 3 +++ >> 4 files changed, 16 insertions(+), 2 deletions(-) >> >> -- >> 2.17.1 >> > > Thanks > Dave >