From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Karina Yankevich <k.yankevich@omp.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] usb: storage: sddr55: avoid integer overflow
Date: Mon, 6 Feb 2023 23:04:54 +0300 [thread overview]
Message-ID: <53bc0584-51eb-8bb7-de48-ca07fccafc19@gmail.com> (raw)
In-Reply-To: <Y91zL8OWTUd8iTXt@rowland.harvard.edu>
Hello!
On 2/3/23 11:48 PM, Alan Stern wrote:
[...]
>> We're possibly losing information by shifting an int.
>> Fix it by adding the necessary cast.
>
> Nonsense. The card's _total_ capacity is no larger than 128 MB, so a
> page address can't possibly overflow an int.
Then the 'address' variables shouldn't be declared *unsigned long*, right?
That should fix the SVACE's report as well. Would you accept such a patch?
> Alan Stern
[...]
MBR, Sergey
next prev parent reply other threads:[~2023-02-06 20:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:18 [PATCH] usb: storage: sddr55: avoid integer overflow Karina Yankevich
2023-02-03 20:48 ` Alan Stern
2023-02-06 20:04 ` Sergei Shtylyov [this message]
2023-02-06 20:17 ` Alan Stern
2023-02-27 11:25 ` [PATCH v2] usb: storage: sddr55: clean up variable type Karina Yankevich
2023-02-27 11:54 ` Greg Kroah-Hartman
2023-12-01 16:16 ` Sergei Shtylyov
2023-12-01 22:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53bc0584-51eb-8bb7-de48-ca07fccafc19@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.yankevich@omp.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.