From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E33E810D5 for ; Thu, 28 Sep 2023 02:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229437AbjI1CDY (ORCPT ); Wed, 27 Sep 2023 22:03:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbjI1CDX (ORCPT ); Wed, 27 Sep 2023 22:03:23 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD4CAC1; Wed, 27 Sep 2023 19:03:21 -0700 (PDT) Received: from kwepemd500002.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RwxVn50XczNnmP; Thu, 28 Sep 2023 09:59:29 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemd500002.china.huawei.com (7.221.188.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.23; Thu, 28 Sep 2023 10:03:19 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.031; Thu, 28 Sep 2023 10:03:19 +0800 From: "Gonglei (Arei)" To: zhenwei pi , "Michael S. Tsirkin" CC: Halil Pasic , Herbert Xu , "linux-crypto@vger.kernel.org" , Marc Hartmayer , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , Cornelia Huck Subject: RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled Thread-Topic: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled Thread-Index: AdnvwZyqMOU4LXJLQHSIVFGYJFXR5QAk7LIAAAEdD4AAMnHjIP//vvqAgADI4ID//3VFcA== Date: Thu, 28 Sep 2023 02:03:18 +0000 Message-ID: <53d400c057564aa28930bbf3d76ddeff@huawei.com> References: <1914739e2de14ed396e5674aa2d4766c@huawei.com> <20230926184158.4ca2c0c3.pasic@linux.ibm.com> <20230926130521-mutt-send-email-mst@kernel.org> <9564c220c8344939880bb805c5b3cac9@huawei.com> <20230927152531.061600f0.pasic@linux.ibm.com> <829bc434-89e6-b17e-b832-d0d83480c80f@bytedance.com> In-Reply-To: <829bc434-89e6-b17e-b832-d0d83480c80f@bytedance.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogemhlbndlaSBwaSBbbWFp bHRvOnBpemhlbndlaUBieXRlZGFuY2UuY29tXQ0KPiBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVy IDI4LCAyMDIzIDk6MjQgQU0NCj4gVG86IE1pY2hhZWwgUy4gVHNpcmtpbiA8bXN0QHJlZGhhdC5j b20+OyBHb25nbGVpIChBcmVpKQ0KPiA8YXJlaS5nb25nbGVpQGh1YXdlaS5jb20+DQo+IENjOiBI YWxpbCBQYXNpYyA8cGFzaWNAbGludXguaWJtLmNvbT47IEhlcmJlcnQgWHUNCj4gPGhlcmJlcnRA Z29uZG9yLmFwYW5hLm9yZy5hdT47IGxpbnV4LWNyeXB0b0B2Z2VyLmtlcm5lbC5vcmc7IE1hcmMN Cj4gSGFydG1heWVyIDxtaGFydG1heUBsaW51eC5pYm0uY29tPjsgSmFzb24gV2FuZw0KPiA8amFz b3dhbmdAcmVkaGF0LmNvbT47IHZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnOw0KPiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOyBDb3JuZWxpYSBIdWNrIDxjb2h1 Y2tAcmVkaGF0LmNvbT4NCj4gU3ViamVjdDogUmU6IFJlOiBbUEFUQ0hdIGNyeXB0bzogdmlydGlv LWNyeXB0bzogY2FsbCBmaW5hbGl6ZSB3aXRoIGJoIGRpc2FibGVkDQo+IA0KPiBIaSBNaWNoYWVs ICYgTGVpLA0KPiANCj4gSSB2b2x1bnRlZXIgdG8gZml4IHRoaXMgYnkgd29ya3F1ZXVlLg0KPiAN ClRoYW5rcywgcGF0Y2hlcyBhcmUgYWx3YXlzIHdlbGNvbWUuDQoNCj4gSSBhbHNvIG5vdGljZSB0 aGF0IGRldmljZSBkcml2ZXJzIHVzZSB3b3JrcXVldWUgdG8gaGFuZGxlIGNvbmZpZy1jaGFuZ2Vk IGFnYWluDQo+IGFuZCBhZ2Fpbiwgd2hhdCBhYm91dCByZS1pbXBsZW1lbnQgX192aXJ0aW9fY29u ZmlnX2NoYW5nZWQoKSBieSBraWNraW5nDQo+IHdvcmtxdWV1ZSBpbnN0ZWFkPw0KPiANClBlcnNv bmFsbHksIEkgcHJlZmVyIHRvIGltcGxlbWVudCBpdCBpbiB0aGUgZGV2aWNlIGRyaXZlciBjYXNl IGJ5IGNhc2UuIHNvbWUgZGV2aWNlcyANCndhbnQgdG8gd29yayBpbiB0aGUgdXBwZXIgaGFsZiBv ZiB0aGUgaW50ZXJydXB0IGNvbnRleHQsIHN1Y2ggYXMgdmlydGlvLW1lbS4NCg0KPiBCeSB0aGUg d2F5LCBiYWxsb29uIGRpcnZlcnMgdXNlcw0KPiBzcGluX2xvY2tfaXJxc2F2ZS9zcGluX3VubG9j a19pcnFyZXN0b3JlIGluIGNvbmZpZy1jaGFuZ2VkIGNhbGxiYWNrLCBkbyBpdA0KPiBoYW5kbGUg Y29ycmVjdGx5Pw0KPiANCkl0J3Mgb2suIFRoZSBjcml0aWNhbCByZXNvdXJjZSBwcm90ZWN0ZWQg aXMgZ2xvYmFsIHN5c3RlbV9mcmVlemFibGVfd3EuDQoNClJlZ2FyZHMsDQotR29uZ2xlaQ0KDQo+ IE9uIDkvMjcvMjMgMjE6MjUsIEhhbGlsIFBhc2ljIHdyb3RlOg0KPiA+IE9uIFdlZCwgMjcgU2Vw IDIwMjMgMDk6MjQ6MDkgKzAwMDANCj4gPiAiR29uZ2xlaSAoQXJlaSkiIDxhcmVpLmdvbmdsZWlA aHVhd2VpLmNvbT4gd3JvdGU6DQo+ID4NCj4gPj4+IE9uIGEgcmVsYXRlZCBub3RlLCBjb25maWcg Y2hhbmdlIGNhbGxiYWNrIGlzIGFsc28gaGFuZGxlZA0KPiA+Pj4gaW5jb3JyZWN0bHkgaW4gdGhp cyBkcml2ZXIsIGl0IHRha2VzIGEgbXV0ZXggZnJvbSBpbnRlcnJ1cHQgY29udGV4dC4NCj4gPj4N Cj4gPj4gR29vZCBjYXRjaC4gV2lsbCBmaXggaXQuDQo+ID4NCj4gPiBUaGFua3MgR29uZ2xlaSEg U29ycnkgSSBmaXJzdCBtaXN1bmRlcnN0b29kIHRoaXMgYXMgYSBwcm9ibGVtIHdpdGhpbg0KPiA+ IHRoZSB2aXJ0aW8tY2N3IGRyaXZlciwgYnV0IGl0IGlzIGFjdHVhbGx5IGFib3V0IHZpcnRpby1j cnlwdG8uIFRoYW5rcw0KPiA+IGZvciBmaXhpbmcgdGhpcyENCj4gPg0KPiA+IFJlZ2FyZHMsDQo+ ID4gSGFsaWwNCj4gDQo+IC0tDQo+IHpoZW53ZWkgcGkNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 323E7E810DF for ; Thu, 28 Sep 2023 02:03:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A917061593; Thu, 28 Sep 2023 02:03:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A917061593 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P8V08McaZ1rc; Thu, 28 Sep 2023 02:03:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 063616156B; Thu, 28 Sep 2023 02:03:28 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 063616156B Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D26BBC0039; Thu, 28 Sep 2023 02:03:28 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id DD7BEC0032 for ; Thu, 28 Sep 2023 02:03:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AA3FD424EB for ; Thu, 28 Sep 2023 02:03:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AA3FD424EB X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ix1Y9tvoCbC for ; Thu, 28 Sep 2023 02:03:25 +0000 (UTC) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0216442414 for ; Thu, 28 Sep 2023 02:03:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0216442414 Received: from kwepemd500002.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RwxVn50XczNnmP; Thu, 28 Sep 2023 09:59:29 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemd500002.china.huawei.com (7.221.188.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.23; Thu, 28 Sep 2023 10:03:19 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2507.031; Thu, 28 Sep 2023 10:03:19 +0800 To: zhenwei pi , "Michael S. Tsirkin" Subject: RE: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled Thread-Topic: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled Thread-Index: AdnvwZyqMOU4LXJLQHSIVFGYJFXR5QAk7LIAAAEdD4AAMnHjIP//vvqAgADI4ID//3VFcA== Date: Thu, 28 Sep 2023 02:03:18 +0000 Message-ID: <53d400c057564aa28930bbf3d76ddeff@huawei.com> References: <1914739e2de14ed396e5674aa2d4766c@huawei.com> <20230926184158.4ca2c0c3.pasic@linux.ibm.com> <20230926130521-mutt-send-email-mst@kernel.org> <9564c220c8344939880bb805c5b3cac9@huawei.com> <20230927152531.061600f0.pasic@linux.ibm.com> <829bc434-89e6-b17e-b832-d0d83480c80f@bytedance.com> In-Reply-To: <829bc434-89e6-b17e-b832-d0d83480c80f@bytedance.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.149.11] MIME-Version: 1.0 X-CFilter-Loop: Reflected Cc: Herbert Xu , Cornelia Huck , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Halil Pasic , Marc Hartmayer , "linux-crypto@vger.kernel.org" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Gonglei \(Arei\) via Virtualization" Reply-To: "Gonglei \(Arei\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" > -----Original Message----- > From: zhenwei pi [mailto:pizhenwei@bytedance.com] > Sent: Thursday, September 28, 2023 9:24 AM > To: Michael S. Tsirkin ; Gonglei (Arei) > > Cc: Halil Pasic ; Herbert Xu > ; linux-crypto@vger.kernel.org; Marc > Hartmayer ; Jason Wang > ; virtualization@lists.linux-foundation.org; > linux-kernel@vger.kernel.org; Cornelia Huck > Subject: Re: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled > > Hi Michael & Lei, > > I volunteer to fix this by workqueue. > Thanks, patches are always welcome. > I also notice that device drivers use workqueue to handle config-changed again > and again, what about re-implement __virtio_config_changed() by kicking > workqueue instead? > Personally, I prefer to implement it in the device driver case by case. some devices want to work in the upper half of the interrupt context, such as virtio-mem. > By the way, balloon dirvers uses > spin_lock_irqsave/spin_unlock_irqrestore in config-changed callback, do it > handle correctly? > It's ok. The critical resource protected is global system_freezable_wq. Regards, -Gonglei > On 9/27/23 21:25, Halil Pasic wrote: > > On Wed, 27 Sep 2023 09:24:09 +0000 > > "Gonglei (Arei)" wrote: > > > >>> On a related note, config change callback is also handled > >>> incorrectly in this driver, it takes a mutex from interrupt context. > >> > >> Good catch. Will fix it. > > > > Thanks Gonglei! Sorry I first misunderstood this as a problem within > > the virtio-ccw driver, but it is actually about virtio-crypto. Thanks > > for fixing this! > > > > Regards, > > Halil > > -- > zhenwei pi _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization