From: "Luck, Tony" <tony.luck@intel.com>
To: "H. Peter Anvin" <hpa@linux.jf.intel.com>
Cc: Mike Qiu <qiudayu@linux.vnet.ibm.com>,
Randy Dunlap <rdunlap@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: [PATCH] Fix build warnings in aer.h
Date: Tue, 29 Jul 2014 10:49:25 -0700 [thread overview]
Message-ID: <53d7dea511471321bb@agluck-desk.sc.intel.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]
From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
build log:
In file included from include/ras/ras_event.h:11:0,
from drivers/ras/ras.c:13:
include/linux/aer.h:42:129: warning: ‘struct pci_dev’
declared inside parameter list [enabled by default]
include/linux/aer.h:42:129: warning: its scope is only
this definition or declaration, which is probably not
what you want [enabled by default]
include/linux/aer.h:46:130: warning: ‘struct pci_dev’
declared inside parameter list [enabled by default]
include/linux/aer.h:50:136: warning: ‘struct pci_dev’
declared inside parameter list [enabled by default]
include/linux/aer.h:57:14: warning: ‘struct pci_dev’
declared inside parameter list [enabled by default]
Signed-off-by: Mike Qiu <qiudayu@linux.vnet.ibm.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
include/linux/aer.h | 2 ++
1 file changed, 2 insertions(+)
Peter: Can you add this to the x86/ras branch in the tip tree.
There's a change in there that is breaking randconfig
builds in linux-next because something includes aer.h
without including pci.h ... which ought to be legal as
aer.h needs to take responsibility for making sure that
it resolves dependencies itself.
diff --git a/include/linux/aer.h b/include/linux/aer.h
index 4dbaa70..c826d1c 100644
--- a/include/linux/aer.h
+++ b/include/linux/aer.h
@@ -11,6 +11,8 @@
#define AER_FATAL 1
#define AER_CORRECTABLE 2
+struct pci_dev;
+
struct aer_header_log_regs {
unsigned int dw0;
unsigned int dw1;
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2014-07-29 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 17:49 Luck, Tony [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-16 8:08 [PATCH] Fix build warnings in aer.h Mike Qiu
2014-07-16 18:08 ` Bjorn Helgaas
2014-07-22 1:59 ` Mike Qiu
2014-07-22 2:38 ` Bjorn Helgaas
2014-07-22 4:31 ` Randy Dunlap
2014-07-22 13:51 ` Bjorn Helgaas
2014-07-22 16:17 ` Luck, Tony
2014-07-22 4:51 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53d7dea511471321bb@agluck-desk.sc.intel.com \
--to=tony.luck@intel.com \
--cc=bhelgaas@google.com \
--cc=hpa@linux.jf.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=qiudayu@linux.vnet.ibm.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.