All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <graf@amazon.com>,
	Dorjoy Chowdhury <dorjoychy111@gmail.com>,
	qemu-devel@nongnu.org
Cc: agraf@csgraf.de, stefanha@redhat.com, slp@redhat.com,
	richard.henderson@linaro.org, eduardo@habkost.net,
	mst@redhat.com, marcel.apfelbaum@gmail.com, berrange@redhat.com,
	philmd@linaro.org
Subject: Re: [PATCH v8 0/6] AWS Nitro Enclave emulation support
Date: Wed, 30 Oct 2024 12:30:57 +0100	[thread overview]
Message-ID: <53d9a4a5-367e-4049-ae7a-fa3442c46877@redhat.com> (raw)
In-Reply-To: <a9595a5b-e964-4dd0-9725-278141b398a3@amazon.com>

On 10/30/24 09:43, Alexander Graf wrote:
>> Hi,
>>
>> sorry about the delay -- the patches failed CI and I didn't have much
>> time to investigate until now.
>>
>> The issues are basically:
>>
>> 1) some rST syntax errors
>>
>> 2) failures on non-Linux due to lack of VHOST_USER
>>
>> 3) failures on 32-bit due to uint64_t/long mismatch.
>>
>> While fixing (2) I also moved the dependency on libcbor and gnutls from
>> meson to Kconfig, and added --enable-libcbor to configure.  I also split
>> hw/core/eif.c to a separate symbol, just to simplify reproducing the
>> 32-bit failure on the right commit.
>>
>> And finally, VIRTIO_NSM should default to no (the nitro-enclave machne
>> takes care of selecting it).
>>
>> No big deal; it's easier done than described.  See attached patch for
>> the differences.
> 
> Thanks a bunch for looking deeply and fixing the issues above :). I 
> suppose the next step is to post v9 with your changes included?

No, I can see that it wasn't clear but I've queued it. :)

Paolo



  reply	other threads:[~2024-10-30 11:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 21:17 [PATCH v8 0/6] AWS Nitro Enclave emulation support Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 1/6] tests/lcitool: Update libvirt-ci and add libcbor dependency Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 2/6] device/virtio-nsm: Support for Nitro Secure Module device Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 3/6] hw/core: Add Enclave Image Format (EIF) related helpers Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 4/6] core/machine: Make create_default_memdev machine class property Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 5/6] machine/nitro-enclave: New machine type for AWS Nitro Enclaves Dorjoy Chowdhury
2024-10-08 21:17 ` [PATCH v8 6/6] docs/nitro-enclave: Documentation for nitro-enclave machine type Dorjoy Chowdhury
2024-10-09 12:24 ` [PATCH v8 0/6] AWS Nitro Enclave emulation support Alexander Graf
2024-10-16 13:58   ` Dorjoy Chowdhury
2024-10-23 14:27     ` Dorjoy Chowdhury
2024-10-29 19:32       ` Paolo Bonzini
2024-10-29 20:08         ` Dorjoy Chowdhury
2024-10-30  7:03           ` Paolo Bonzini
2024-10-30  7:16             ` Dorjoy Chowdhury
2024-10-30  8:43         ` Alexander Graf
2024-10-30 11:30           ` Paolo Bonzini [this message]
2024-10-30 11:39             ` Dorjoy Chowdhury

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53d9a4a5-367e-4049-ae7a-fa3442c46877@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@csgraf.de \
    --cc=berrange@redhat.com \
    --cc=dorjoychy111@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=graf@amazon.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=slp@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.