All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [GIT PULL FOR v3.18] cx23885: convert to the latest frameworks, including vb2
Date: Fri, 29 Aug 2014 08:37:52 +0200	[thread overview]
Message-ID: <54001FC0.3050701@xs4all.nl> (raw)

Hi Mauro,

This pull request converts the cx23885 driver to the latest V4L2 core
frameworks, removing about 1000 lines in the process.

It now passes the v4l2-compliance tests and, frankly, feels much more
robust.

I have tested this with my HVR-1800 board with video (compressed and
uncompressed), vbi, dvb and alsa, including several duration stress tests.

As usual, the vb2 conversion is a beast of a patch. But the vb2 conversion
affected video, vbi, dvb and alsa, so it's all over the place. And it is
all or nothing. See the commit log of that patch for some more information.

It also changed the risc code to simplify the code and to get rid of all
the timeouts that were copied-and-pasted from cx88. If anyone knows of a
reason for these timeouts, please let me know. I have tried to separate the
risc code changes from the vb2 changes, but that was impossible to get to
work with vb1.

I dropped the vb2 fix I included in my earlier pull request since that fix
will appear in v3.17 (i.e. before this driver is upstreamed) anyway.

Regards,

	Hans

The following changes since commit b250392f7b5062cf026b1423e27265e278fd6b30:

  [media] media: ttpci: fix av7110 build to be compatible with CONFIG_INPUT_EVDEV (2014-08-21 15:25:38 -0500)

are available in the git repository at:

  git://linuxtv.org/hverkuil/media_tree.git cx23b

for you to fetch changes up to 7552750cc31d5925b9d44eb2a5c98504fa64c38b:

  cx23885: Add busy checks before changing formats (2014-08-29 08:31:53 +0200)

----------------------------------------------------------------
Hans Verkuil (20):
      cx23885: fix querycap
      cx23885: fix audio input handling
      cx23885: support v4l2_fh and g/s_priority
      cx23885: use core locking, switch to unlocked_ioctl.
      cx23885: convert to the control framework
      cx23885: convert 417 to the control framework
      cx23885: fix format colorspace compliance error
      cx23885: map invalid fields to a valid field.
      cx23885: drop radio-related dead code
      cx23885: drop type field from struct cx23885_fh
      cx23885: drop unused clip fields from struct cx23885_fh
      cx23885: fmt, width and height are global, not per-fh.
      cx23885: drop videobuf abuse in cx23885-alsa
      cx23885: use video_drvdata to get cx23885_dev pointer
      cx23885: convert to vb2
      cx23885: fix field handling
      cx23885: fix weird sizes.
      cx23885: remove FSF address as per checkpatch
      cx23885: remove btcx-risc dependency
      cx23885: Add busy checks before changing formats

 drivers/media/pci/cx23885/Kconfig         |    5 +-
 drivers/media/pci/cx23885/Makefile        |    1 -
 drivers/media/pci/cx23885/altera-ci.c     |    8 +-
 drivers/media/pci/cx23885/altera-ci.h     |    4 -
 drivers/media/pci/cx23885/cimax2.c        |    4 -
 drivers/media/pci/cx23885/cimax2.h        |    4 -
 drivers/media/pci/cx23885/cx23885-417.c   |  501 ++++++++++---------------------
 drivers/media/pci/cx23885/cx23885-alsa.c  |  109 +++++--
 drivers/media/pci/cx23885/cx23885-av.c    |    5 -
 drivers/media/pci/cx23885/cx23885-av.h    |    5 -
 drivers/media/pci/cx23885/cx23885-cards.c |    6 -
 drivers/media/pci/cx23885/cx23885-core.c  |  362 ++++++++---------------
 drivers/media/pci/cx23885/cx23885-dvb.c   |  136 ++++++---
 drivers/media/pci/cx23885/cx23885-f300.c  |    4 -
 drivers/media/pci/cx23885/cx23885-i2c.c   |   12 -
 drivers/media/pci/cx23885/cx23885-input.c |    5 -
 drivers/media/pci/cx23885/cx23885-input.h |    5 -
 drivers/media/pci/cx23885/cx23885-ioctl.c |   10 +-
 drivers/media/pci/cx23885/cx23885-ioctl.h |    4 -
 drivers/media/pci/cx23885/cx23885-ir.c    |    5 -
 drivers/media/pci/cx23885/cx23885-ir.h    |    5 -
 drivers/media/pci/cx23885/cx23885-reg.h   |    4 -
 drivers/media/pci/cx23885/cx23885-vbi.c   |  282 ++++++++----------
 drivers/media/pci/cx23885/cx23885-video.c | 1294 +++++++++++++++++++++------------------------------------------------------------
 drivers/media/pci/cx23885/cx23885-video.h |    5 -
 drivers/media/pci/cx23885/cx23885.h       |  127 +++-----
 drivers/media/pci/cx23885/cx23888-ir.c    |    5 -
 drivers/media/pci/cx23885/cx23888-ir.h    |    5 -
 drivers/media/pci/cx23885/netup-eeprom.c  |    4 -
 drivers/media/pci/cx23885/netup-eeprom.h  |    4 -
 drivers/media/pci/cx23885/netup-init.c    |    4 -
 drivers/media/pci/cx23885/netup-init.h    |    4 -
 32 files changed, 951 insertions(+), 1987 deletions(-)

             reply	other threads:[~2014-08-29  6:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  6:37 Hans Verkuil [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-14 10:06 [GIT PULL FOR v3.18] cx23885: convert to the latest frameworks, including vb2 Hans Verkuil
2014-09-03 11:39 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54001FC0.3050701@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.