From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH] drm: add checking DRM_FORMAT_NV12MT Date: Fri, 29 Aug 2014 16:21:15 +0900 Message-ID: <540029EB.9040905@samsung.com> References: <1406522861-19532-1-git-send-email-jy0922.shim@samsung.com> <20140728160832.GM27580@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 57F566E2D3 for ; Fri, 29 Aug 2014 00:21:17 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NB2007EQ4FF9380@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 29 Aug 2014 16:21:15 +0900 (KST) In-reply-to: <20140728160832.GM27580@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: airlied@gmail.com, Joonyoung Shim Cc: Seung-Woo Kim , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org Hi Dave, On 07/29/2014 01:08 AM, Ville Syrj=E4l=E4 wrote: > On Mon, Jul 28, 2014 at 11:56:59AM -0400, Rob Clark wrote: >> On Mon, Jul 28, 2014 at 12:47 AM, Joonyoung Shim >> wrote: >>> If user NV12MT uses as pixel format, the Addfb2 ioctl is failed because >>> of missing to check DRM_FORMAT_NV12MT. The NV12MT pixel format is >>> supported by exynos4 and some qualcomm chipset and it is used by exynos >>> drm driver. If there is no any objection, could you merge this? Thanks. >> >> tbh, format_check() should probably just be made to respect the >> formats advertised by all the planes.. > = > That can't be done until all drivers are converted to primary/cursor > planes. Also I'm not sure if we should allow it even then since that > would make it quite easy to sneak in new driver specific formats > without anyone necessarily reviewing them. > = >> >> BR, >> -R >> >>> Signed-off-by: Joonyoung Shim >>> --- >>> drivers/gpu/drm/drm_crtc.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c >>> index 1ccf5cb..5d7bd49 100644 >>> --- a/drivers/gpu/drm/drm_crtc.c >>> +++ b/drivers/gpu/drm/drm_crtc.c >>> @@ -2960,6 +2960,7 @@ static int format_check(const struct drm_mode_fb_= cmd2 *r) >>> case DRM_FORMAT_NV61: >>> case DRM_FORMAT_NV24: >>> case DRM_FORMAT_NV42: >>> + case DRM_FORMAT_NV12MT: >>> case DRM_FORMAT_YUV410: >>> case DRM_FORMAT_YVU410: >>> case DRM_FORMAT_YUV411: >>> @@ -4800,6 +4801,7 @@ int drm_format_num_planes(uint32_t format) >>> case DRM_FORMAT_NV61: >>> case DRM_FORMAT_NV24: >>> case DRM_FORMAT_NV42: >>> + case DRM_FORMAT_NV12MT: >>> return 2; >>> default: >>> return 1; >>> @@ -4835,6 +4837,7 @@ int drm_format_plane_cpp(uint32_t format, int pla= ne) >>> case DRM_FORMAT_NV61: >>> case DRM_FORMAT_NV24: >>> case DRM_FORMAT_NV42: >>> + case DRM_FORMAT_NV12MT: >>> return plane ? 2 : 1; >>> case DRM_FORMAT_YUV410: >>> case DRM_FORMAT_YVU410: >>> @@ -4878,6 +4881,7 @@ int drm_format_horz_chroma_subsampling(uint32_t f= ormat) >>> case DRM_FORMAT_NV21: >>> case DRM_FORMAT_NV16: >>> case DRM_FORMAT_NV61: >>> + case DRM_FORMAT_NV12MT: >>> case DRM_FORMAT_YUV422: >>> case DRM_FORMAT_YVU422: >>> case DRM_FORMAT_YUV420: >>> @@ -4907,6 +4911,7 @@ int drm_format_vert_chroma_subsampling(uint32_t f= ormat) >>> case DRM_FORMAT_YVU420: >>> case DRM_FORMAT_NV12: >>> case DRM_FORMAT_NV21: >>> + case DRM_FORMAT_NV12MT: >>> return 2; >>> default: >>> return 1; >>> -- >>> 1.8.1.2 >>> >>> _______________________________________________ >>> dri-devel mailing list >>> dri-devel@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/dri-devel >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > =